From: David Miller <davem@davemloft.net>
To: johnpol@2ka.mipt.ru
Cc: shemminger@linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [Bug 8013] New: select for write hangs on a socket after write returned ECONNRESET
Date: Thu, 22 Feb 2007 05:31:38 -0800 (PST) [thread overview]
Message-ID: <20070222.053138.74748069.davem@davemloft.net> (raw)
In-Reply-To: <20070222121427.GA29455@2ka.mipt.ru>
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Date: Thu, 22 Feb 2007 15:14:27 +0300
> if (sk->sk_shutdown == SHUTDOWN_MASK || sk->sk_state == TCP_CLOSE)
> mask |= POLLHUP;
>
> to
>
> if (sk->sk_shutdown == SHUTDOWN_MASK || sk->sk_state == TCP_CLOSE)
> mask |= POLLHUP | (sk->sk_state == TCP_CLOSE)?POLLERR:0;
>
>
> Thoughts?
TCP_CLOSE is where we end up on a non-error close too, this has
the same kind of bug as your previous attempt to set POLLERR
here.
One side gets TCP_TIMEWAIT the other goes straight to TCP_CLOSE.
It really is not possible to change current semantics, they are the
best possible unfortunately.
next prev parent reply other threads:[~2007-02-22 13:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-16 0:04 Fw: [Bug 8013] New: select for write hangs on a socket after write returned ECONNRESET Stephen Hemminger
2007-02-16 15:25 ` Evgeniy Polyakov
2007-02-16 15:28 ` Evgeniy Polyakov
2007-02-16 15:39 ` Evgeniy Polyakov
2007-02-16 15:54 ` Evgeniy Polyakov
2007-02-16 16:10 ` Evgeniy Polyakov
2007-02-16 18:29 ` Stephen Hemminger
2007-02-16 18:34 ` Evgeniy Polyakov
2007-02-17 16:25 ` Evgeniy Polyakov
2007-02-19 14:19 ` Jarek Poplawski
2007-02-22 6:47 ` David Miller
2007-02-22 6:45 ` David Miller
2007-02-22 12:14 ` Evgeniy Polyakov
2007-02-22 13:31 ` David Miller [this message]
2007-02-22 13:46 ` Evgeniy Polyakov
2007-02-22 14:08 ` David Miller
2007-02-22 18:24 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070222.053138.74748069.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=johnpol@2ka.mipt.ru \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).