From mboxrd@z Thu Jan 1 00:00:00 1970 From: YOSHIFUJI Hideaki / =?iso-2022-jp?B?GyRCNUhGIzFRTEAbKEI=?= Subject: Re: [PATCH 2/7] cxgb3 - private ioctl cleanup Date: Thu, 22 Feb 2007 21:06:18 +0900 (JST) Message-ID: <20070222.210618.134161490.yoshfuji@linux-ipv6.org> References: <20070222115925.10001.61276.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jeff@garzik.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, swise@opengridcomputing.com, yoshfuji@linux-ipv6.org To: divy@chelsio.com Return-path: Received: from yue.linux-ipv6.org ([203.178.140.15]:57088 "EHLO yue.st-paulia.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1945978AbXBVMGL (ORCPT ); Thu, 22 Feb 2007 07:06:11 -0500 In-Reply-To: <20070222115925.10001.61276.stgit@localhost.localdomain> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org In article <20070222115925.10001.61276.stgit@localhost.localdomain> (at Thu, 22 Feb 2007 03:59:25 -0800), divy@chelsio.com says: > From: Divy Le Ray > > Clean up some private ioctls. > > Signed-off-by: Divy Le Ray > --- > > drivers/net/cxgb3/cxgb3_ioctl.h | 21 ++++------------- > drivers/net/cxgb3/cxgb3_main.c | 48 +++------------------------------------ > 2 files changed, 9 insertions(+), 60 deletions(-) > > diff --git a/drivers/net/cxgb3/cxgb3_ioctl.h b/drivers/net/cxgb3/cxgb3_ioctl.h > index a942818..42d4bf6 100644 > --- a/drivers/net/cxgb3/cxgb3_ioctl.h > +++ b/drivers/net/cxgb3/cxgb3_ioctl.h > @@ -36,28 +36,17 @@ > * Ioctl commands specific to this driver. > */ > enum { > - CHELSIO_SETREG = 1024, > - CHELSIO_GETREG, > - CHELSIO_SETTPI, > - CHELSIO_GETTPI, > - CHELSIO_GETMTUTAB, > + CHELSIO_GETMTUTAB = 1024, > CHELSIO_SETMTUTAB, > - CHELSIO_GETMTU, > - CHELSIO_SET_PM, > - CHELSIO_GET_PM, > - CHELSIO_GET_TCAM, > - CHELSIO_SET_TCAM, > - CHELSIO_GET_TCB, > CHELSIO_GET_MEM, > CHELSIO_LOAD_FW, > - CHELSIO_GET_PROTO, > - CHELSIO_SET_PROTO, > CHELSIO_SET_TRACE_FILTER, > - CHELSIO_SET_QSET_PARAMS, > CHELSIO_GET_QSET_PARAMS, > - CHELSIO_SET_QSET_NUM, > + CHELSIO_SET_QSET_PARAMS, > CHELSIO_GET_QSET_NUM, > - CHELSIO_SET_PKTSCHED, > + CHELSIO_SET_QSET_NUM, > + CHELSIO_GET_PM, > + CHELSIO_SET_PM, > }; > I disagree. This is very bad. 1. Please do do change the values. 2. Explain why you are going to kill these ioctls. Regards, --yoshfuji