From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: netdev@vger.kernel.org
Subject: [PATCH 1/2] sky2: fix for NAPI with dual port boards
Date: Wed, 21 Feb 2007 16:04:42 -0800 [thread overview]
Message-ID: <20070222000621.673620000@linux-foundation.org> (raw)
In-Reply-To: 20070222000441.469009000@linux-foundation.org
[-- Attachment #1: sky2-napi-dual.patch --]
[-- Type: text/plain, Size: 941 bytes --]
This driver uses port 0 to handle receives on both ports. So
the netif_poll_disable call in dev_close would end up stopping the
second port on dual port cards.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
---
drivers/net/sky2.c | 7 +++++++
1 file changed, 7 insertions(+)
--- linux-2.6.16.40.orig/drivers/net/sky2.c 2007-02-21 15:57:56.000000000 -0800
+++ linux-2.6.16.40/drivers/net/sky2.c 2007-02-21 15:58:02.000000000 -0800
@@ -1402,6 +1402,13 @@
/* Stop more packets from being queued */
netif_stop_queue(dev);
+ /*
+ * Both ports share the NAPI poll on port 0, so if necessary undo the
+ * the disable that is done in dev_close.
+ */
+ if (sky2->port == 0 && hw->ports > 1)
+ netif_poll_enable(dev);
+
/* Disable port IRQ */
spin_lock_irq(&hw->hw_lock);
hw->intr_mask &= ~((sky2->port == 0) ? Y2_IS_IRQ_PHY1 : Y2_IS_IRQ_PHY2);
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-02-22 0:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-22 0:04 [PATCH 0/2] sky2: patches for 2.6.16 -stable Stephen Hemminger
2007-02-22 0:04 ` Stephen Hemminger [this message]
2007-02-22 0:04 ` [PATCH 2/2] sky2: dual-port pci-x checksum fix Stephen Hemminger
2007-02-22 20:08 ` [PATCH 0/2] sky2: patches for 2.6.16 -stable Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070222000621.673620000@linux-foundation.org \
--to=shemminger@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).