From: Eric Dumazet <dada1@cosmosbay.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] TCP : keep copied_seq, rcv_wup and rcv_next together
Date: Thu, 22 Feb 2007 11:43:32 +0100 [thread overview]
Message-ID: <200702221143.32622.dada1@cosmosbay.com> (raw)
In-Reply-To: <20070222.023220.92577095.davem@davemloft.net>
On Thursday 22 February 2007 11:32, David Miller wrote:
> From: Eric Dumazet <dada1@cosmosbay.com>
> Date: Thu, 22 Feb 2007 11:22:02 +0100
>
> > rcv_wup and copied_seq should be next to rcv_nxt field, to lower number
> > of active cache lines in hot paths. (tcp_rcv_established(), tcp_poll(),
> > ...)
>
> Please fixup the assignment order in tcp_create_openreq_child() else
> we'll get a new store buffer stall during socket creation :-)
OK :)
I wonder if :
newtp->snd_nxt = newtp->snd_una = newtp->snd_sml = treq->snt_isn + 1;
is correct, since compiler will write snd_sml, then snd_una, and snd_nxt
Maybe we should also reorder this too ?
Eric
next prev parent reply other threads:[~2007-02-22 10:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-15 23:46 [PATCH] Use random32() in net/ipv4/multipath Joe Perches
2007-02-22 9:26 ` David Miller
2007-02-22 10:22 ` [PATCH] TCP : keep copied_seq, rcv_wup and rcv_next together Eric Dumazet
2007-02-22 10:32 ` David Miller
2007-02-22 10:43 ` Eric Dumazet [this message]
2007-02-22 11:02 ` David Miller
2007-02-22 11:11 ` [PATCH, take 2] " Eric Dumazet
2007-02-22 11:22 ` David Miller
2007-02-22 14:50 ` [PATCH] NET : keep sk_backlog near sk_lock Eric Dumazet
2007-03-05 0:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702221143.32622.dada1@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).