From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: bwalle@suse.de, miika@iki.fi, netdev@vger.kernel.org
Subject: Re: [PATCH] Fix oops in xfrm4_dst_destroy()
Date: Mon, 26 Feb 2007 12:10:49 -0800 (PST) [thread overview]
Message-ID: <20070226.121049.90121540.davem@davemloft.net> (raw)
In-Reply-To: <45E228C5.3060108@trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Mon, 26 Feb 2007 01:24:37 +0100
> Bernhard Walle wrote:
> > With 2.6.21-rc1, I get an oops when running 'ifdown eth0' and an IPsec
> > connection is active. If I shut down the connection before running 'ifdown
> > eth0', then there's no problem. The critical operation of this script is to
> > kill dhcpd.
> >
> > The problem is probably caused by commit with git identifier
> > 4337226228e1cfc1d70ee975789c6bd070fb597c (Linus tree) "[IPSEC]: IPv4 over IPv6
> > IPsec tunnel".
> >
> > This patch fixes that oops. I don't know the network code of the Linux kernel
> > in deep, so if that fix is wrong, please change it. But please fix the oops. :)
>
> Looks good, when the xfrm_dst is freed in __xfrm4_bundle_create
> after a failed call to xfrm_dst_lookup the xfrm pointer is not
> set, and this is also expected by xfrm_dst_destroy.
>
> Acked-by: Patrick McHardy <kaber@trash.net>
Patch applied, thanks everyone.
prev parent reply other threads:[~2007-02-26 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-25 20:43 [PATCH] Fix oops in xfrm4_dst_destroy() Bernhard Walle
2007-02-26 0:24 ` Patrick McHardy
2007-02-26 20:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070226.121049.90121540.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bwalle@suse.de \
--cc=kaber@trash.net \
--cc=miika@iki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).