From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Roland Dreier <rdreier@cisco.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, netdev@vger.kernel.org
Subject: Re: [PATCH, RESEND] chelsio: Fix non-NAPI compile
Date: Mon, 26 Feb 2007 15:00:00 -0800 [thread overview]
Message-ID: <20070226150000.45347455@freekitty> (raw)
In-Reply-To: <ada1wkczfti.fsf_-_@cisco.com>
On Mon, 26 Feb 2007 14:58:49 -0800
Roland Dreier <rdreier@cisco.com> wrote:
> Chelsio without NAPI enabled has been broken (won't compile) since
> 3de00b89 ("chelsio: NAPI speed improvement"):
>
> drivers/net/chelsio/sge.c: In function `t1_interrupt`:
> drivers/net/chelsio/sge.c:1716: error: `Q` undeclared (first use in this function)
>
> The change below seems to add back in the declaration and
> initialization of `Q` that was removed by mistake, and at least makes
> the driver compile for me, although I have no hardware and hence no
> way to test whether this actually works.
>
> Signed-off-by: Roland Dreier <rolandd@cisco.com>
> ---
> Jeff, I haven't seen any response from Stephen but Divy from Chelsio
> seemed to agree with this patch, so can you please merge it? Right
> now the build is broken with CONFIG_CHELSIO_T1_NAPI=n.
>
> Thanks.
>
>
I agree it was an obvious goof.
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-02-26 23:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-20 23:57 [PATCH 0/3] chelsio 10G driver cleanups Stephen Hemminger
2007-02-20 23:58 ` [PATCH 1/3] chelsio: remove unused code for 1G boards Stephen Hemminger
2007-02-27 9:32 ` Jeff Garzik
2007-02-20 23:58 ` [PATCH 2/3] chelsio: use C99 style initialization Stephen Hemminger
2007-02-20 23:58 ` [PATCH 3/3] chelsio: use const for virtual functions Stephen Hemminger
2007-02-21 7:59 ` [PATCH] chelsio: Fix non-NAPI compile Roland Dreier
2007-02-21 8:05 ` Divy Le Ray
2007-02-26 22:58 ` [PATCH, RESEND] " Roland Dreier
2007-02-26 23:00 ` Stephen Hemminger [this message]
2007-02-27 9:28 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070226150000.45347455@freekitty \
--to=shemminger@linux-foundation.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).