From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: 2.6.20-rc4-mm1: PCI=n: drivers/net/3c59x.c compile error Date: Mon, 26 Feb 2007 13:14:01 -0800 Message-ID: <20070226211401.GC3810@kroah.com> References: <20070111222627.66bb75ab.akpm@osdl.org> <20070124135354.GI17836@stusta.de> <45B76946.1070009@ru.mvista.com> <45D756D7.4060106@ru.mvista.com> <45D75853.1060607@ru.mvista.com> <45E2DF13.9010200@ru.mvista.com> <20070226092644.aea76b37.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Sergei Shtylyov , linux-pci@atrey.karlin.mff.cuni.cz, Adrian Bunk , Andrew Morton , Jeff Garzik , linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: Randy Dunlap Return-path: Content-Disposition: inline In-Reply-To: <20070226092644.aea76b37.randy.dunlap@oracle.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, Feb 26, 2007 at 09:26:44AM -0800, Randy Dunlap wrote: > On Mon, 26 Feb 2007 16:22:27 +0300 Sergei Shtylyov wrote: > > > Hello, I wrote: > > > > >>>> 3x59x-fix-pci-resource-management.patch causes the following compile > > >>>> error with CONFIG_PCI=n: > > > > >>>> <-- snip --> > > > > >>>> ... > > >>>> CC drivers/net/3c59x.o > > >>>> /home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/net/3c59x.c: > > >>>> In function 'vortex_init_one': > > >>>> /home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/net/3c59x.c:961: > > >>>> error: implicit declaration of function 'pci_request_regions' > > >>>> /home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/net/3c59x.c:985: > > >>>> error: implicit declaration of function 'pci_release_regions' > > >>>> make[3]: *** [drivers/net/3c59x.o] Error 1 > > > > >>> Grr, at at the same time it's happy with pci_enable_device(). > > >>> I'd say the problem is in , not in the patch. > > > > >> Has there been any patch to fix the "unbalanced" > > >> pci_{request|release}_regions() declarations? Am I suposed to create > > >> such? > > > > > Alternatively, vortex_{init|remove_one() and struct pci_driver there > > > could have been put under #ifdef CONFIG_PCI (good idea anyway -- should > > > reduce driver size on non-PCI systems)... > > > > I wonder if I may count on any feedback on this -- asking linux-pci now... > > The issue is as follows: with my patch pci_{request|release}_regions() may > > be called with CONFIG_PCI=n (probably, this never has been a issue before) but > > don't have them declared in this case -- unlike > > pci_enable_device() which is just empty for CONFIG_PCI=n. > > Now, what kind of approach do I take: > > > > - a "fair one", so that pci_{request|release}_regions() get "balanced" > > declarations in the header like pci_enable_device(); > > > > - a "local one" (and even saving non-PCI kernel from needless bloat), i.e. > > #ifdef out functions that are only meaningful with CONFIG_PCI=y)? > > > > I'm leaning to the second now... > > I'd prefer the fair one -- add stubs to include/linux/pci.h. Me too, please just send me a patch adding them to pci.h so you don't have to have #ifdefs in your .c code. thanks, greg k-h