From: Paul Moore <paul.moore@hp.com>
To: Patrick McHardy <kaber@trash.net>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [NET]: Fix kfree(skb)
Date: Tue, 27 Feb 2007 12:35:22 -0500 [thread overview]
Message-ID: <200702271235.22671.paul.moore@hp.com> (raw)
In-Reply-To: <45E46518.5070100@trash.net>
On Tuesday, February 27 2007 12:06:32 pm Patrick McHardy wrote:
> diff --git a/net/netlabel/netlabel_unlabeled.c
> b/net/netlabel/netlabel_unlabeled.c index 5bc3718..b931ede 100644
> --- a/net/netlabel/netlabel_unlabeled.c
> +++ b/net/netlabel/netlabel_unlabeled.c
> @@ -173,7 +173,7 @@ static int netlbl_unlabel_list(struct sk
> return 0;
>
> list_failure:
> - kfree(ans_skb);
> + kfree_skb(ans_skb);
> return ret_val;
> }
Acked-by: Paul Moore <paul.moore@hp.com>
Thanks for catching this, it looks like I used kfree_skb() elsewhere but for
some reason missed it here.
--
paul moore
linux security @ hp
next prev parent reply other threads:[~2007-02-27 17:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-27 17:06 [NET]: Fix kfree(skb) Patrick McHardy
2007-02-27 17:35 ` Paul Moore [this message]
2007-02-27 18:00 ` David Miller
2007-02-27 18:14 ` Evgeniy Polyakov
2007-02-27 18:20 ` Evgeniy Polyakov
2007-02-27 18:24 ` David Miller
2007-02-27 22:24 ` Arnaldo Carvalho de Melo
2007-02-28 9:02 ` Run-time kfree check for correct cache [was Re: [NET]: Fix kfree(skb)] Evgeniy Polyakov
2007-02-28 10:10 ` Eric Dumazet
2007-02-28 14:16 ` Run-time kfree check for correct cache [plus x86_64 APIC troubles] Evgeniy Polyakov
2007-03-01 16:17 ` Additional run-tme check [Run-time kfree check for correct cache] Evgeniy Polyakov
2007-02-27 18:01 ` [NET]: Fix kfree(skb) David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702271235.22671.paul.moore@hp.com \
--to=paul.moore@hp.com \
--cc=acme@ghostprotocols.net \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).