From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: kaber@trash.net, netdev@vger.kernel.org
Subject: Re: [NET]: Handle disabled preemption in gfp_any()
Date: Tue, 27 Feb 2007 17:25:11 -0800 [thread overview]
Message-ID: <20070228012510.GD1919@linux.vnet.ibm.com> (raw)
In-Reply-To: <20070227.095657.106265863.davem@davemloft.net>
On Tue, Feb 27, 2007 at 09:56:57AM -0800, David Miller wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Tue, 27 Feb 2007 18:48:19 +0100
>
> > [NET]: Handle disabled preemption in gfp_any()
> >
> > ctnetlink uses netlink_unicast from an atomic_notifier_chain
> > (which is called within a RCU read side critical section)
> > without holding further locks. netlink_unicast calls netlink_trim
> > with the result of gfp_any() for the gfp flags, which are passed
> > down to pskb_expand_header. gfp_any() only checks for softirq
> > context and returns GFP_KERNEL, resulting in this warning:
> >
> > BUG: sleeping function called from invalid context at mm/slab.c:3032
> > in_atomic():1, irqs_disabled():0
> > no locks held by rmmod/7010.
>
> Applied, good catch Patrick.
Breaks -rt, but I will submit a patch to Ingo to that will make this
fix work in the -rt context. I nevertheless agree that this is a good
catch!!!
Thanx, Paul
prev parent reply other threads:[~2007-02-28 1:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-27 17:48 [NET]: Handle disabled preemption in gfp_any() Patrick McHardy
2007-02-27 17:56 ` David Miller
2007-02-28 1:25 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070228012510.GD1919@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).