From: KOVACS Krisztian <hidden@balabit.hu>
To: netdev@vger.kernel.org
Subject: TCP minisock tcp_create_openreq_child() typo?
Date: Wed, 28 Feb 2007 12:03:37 +0100 [thread overview]
Message-ID: <200702281203.38112@nienna> (raw)
Hi,
While reading TCP minisock code I've found this suspiciously looking
code fragment:
- 8< -
struct sock *tcp_create_openreq_child(struct sock *sk, struct request_sock *req, struct sk_buff *skb)
{
struct sock *newsk = inet_csk_clone(sk, req, GFP_ATOMIC);
if (newsk != NULL) {
const struct inet_request_sock *ireq = inet_rsk(req);
struct tcp_request_sock *treq = tcp_rsk(req);
struct inet_connection_sock *newicsk = inet_csk(sk);
struct tcp_sock *newtp;
- 8< -
The above code initializes newicsk to inet_csk(sk), isn't that supposed
to be inet_csk(newsk)? As far as I can tell this might leave
icsk_ack.last_seg_size zero even if we do have received data.
--
Regards,
Krisztian Kovacs
next reply other threads:[~2007-02-28 11:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-28 11:03 KOVACS Krisztian [this message]
2007-02-28 12:10 ` TCP minisock tcp_create_openreq_child() typo? Arnaldo Carvalho de Melo
2007-02-28 19:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702281203.38112@nienna \
--to=hidden@balabit.hu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).