From: Pekka Pietikainen <pp@ee.oulu.fi>
To: netdev@vger.kernel.org, mchan@broadcom.com
Subject: Missing VLAN tags in bnx2
Date: Wed, 28 Feb 2007 21:12:03 +0200 [thread overview]
Message-ID: <20070228191203.GA6576@ee.oulu.fi> (raw)
Just had to spend some time figuring out why a bnx2 card connected to
a switch monitor port didn't see any vlan tags (when in our scenario the
tags are pretty vital). Found the following explanation:
[BNX2]: Fix VLAN on ASF
Always set up the device to strip incoming VLAN tags when ASF is
enabled. ASF firmware will not parse packets correctly if VLAN tags
are not stripped
My fix:
#ifdef I_DONT_KNOW_WHAT_ASF_IS_AND_DONT_REALLY_CARE_EITHER
if (REG_RD_IND(bp, bp->shmem_base + BNX2_PORT_FEATURE) &
BNX2_PORT_FEATURE_ASF_ENABLED)
bp->flags |= ASF_ENABLE_FLAG;
#endif
Any hope of getting this as a ethtool tunable or something similar?
There didn't seem to be a BIOS option for this (Dell PE2900), at least.
next reply other threads:[~2007-02-28 19:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-28 19:12 Pekka Pietikainen [this message]
2007-03-01 1:27 ` Missing VLAN tags in bnx2 Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070228191203.GA6576@ee.oulu.fi \
--to=pp@ee.oulu.fi \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).