From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] NetLabel: Verify sensitivity level has a valid CIPSO mapping Date: Fri, 02 Mar 2007 11:23:47 -0800 (PST) Message-ID: <20070302.112347.126765771.davem@davemloft.net> References: <20070228200140.491071752@hp.com> <200703021112.13063.paul.moore@hp.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jmorris@namei.org To: paul.moore@hp.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:47049 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S965164AbXCBTXs (ORCPT ); Fri, 2 Mar 2007 14:23:48 -0500 In-Reply-To: <200703021112.13063.paul.moore@hp.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Paul Moore Date: Fri, 2 Mar 2007 11:12:12 -0500 > On Wednesday, February 28 2007 3:01:31 pm Paul Moore wrote: > > The current CIPSO engine has a problem where it does not verify that the > > given sensitivity level has a valid CIPSO mapping when the "std" CIPSO DOI > > type is used. The end result is that bad packets are sent on the wire > > which should have never been sent in the first place. This patch corrects > > this problem by verifying the sensitivity level mapping similar to what is > > done with the category mapping. This patch also changes the returned error > > code in this case to -EPERM to better match what the category mapping > > verification code returns. > > > > Signed-off-by: Paul Moore > > --- > > net/ipv4/cipso_ipv4.c | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > I probably should have been more clear in the original patch posting ... this > is a bugfix patch which I believe should go into 2.6.21 (as well as > the -stable tree, but I know they like to see it hit Linus' tree first). I realize this and plan to apply the patch, I'm just backlogged at the moment.