From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: shemminger@linux-foundation.org, bridge@linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [RFC 1/2] bridge: avoid ptype_all packet handling
Date: Fri, 02 Mar 2007 21:59:05 -0800 (PST) [thread overview]
Message-ID: <20070302.215905.74747266.davem@davemloft.net> (raw)
In-Reply-To: <E1HNMxB-0000MP-00@gondolin.me.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 03 Mar 2007 16:38:45 +1100
> This is using packet_bind_spkt which uses a name instead of ifindex.
So it should be just fine, it should be binding to a specific
device (by name instead of ifindex) and therefore it should
only trigger the pt_all hook when the packet arrives on that
specific device.
> As you may recall, I've made a patch to convert it to use the new
> (actually it's not-so-new anymore) AF_PACKET interface.
That's right.
So it's still a mystery why dhcp is causing bridge devices
to trigger the network tap paths on Stephen's machine.
next prev parent reply other threads:[~2007-03-03 5:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-01 1:18 [PATCH] bridge: avoid ptype_all packet handling Stephen Hemminger
2007-03-01 1:28 ` Ben Greear
2007-03-01 3:56 ` Stephen Hemminger
2007-03-01 4:05 ` Ben Greear
2007-03-01 7:04 ` Stephen Hemminger
2007-03-01 7:22 ` David Miller
2007-03-01 7:26 ` Stephen Hemminger
2007-03-01 7:30 ` David Miller
2007-03-01 11:47 ` jamal
2007-03-03 2:14 ` Andi Kleen
2007-03-03 4:22 ` David Miller
2007-03-03 7:09 ` Stephen Hemminger
2007-03-03 12:30 ` Andi Kleen
2007-03-02 21:26 ` David Miller
2007-03-02 22:09 ` [RFC 1/2] " Stephen Hemminger
2007-03-02 22:14 ` [RFC 2/2] bridge: per device promiscious taps Stephen Hemminger
2007-03-02 22:48 ` [RFC 1/2] bridge: avoid ptype_all packet handling David Miller
2007-03-02 23:18 ` David Miller
2007-03-02 23:34 ` Stephen Hemminger
2007-03-02 23:41 ` David Miller
2007-03-03 5:38 ` Herbert Xu
2007-03-03 5:59 ` David Miller [this message]
2007-03-03 6:42 ` Herbert Xu
2007-03-02 22:15 ` Stephen Hemminger
2007-03-03 12:04 ` [PATCH] " Stefan Rompf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070302.215905.74747266.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@linux-foundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).