netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <dada1@cosmosbay.com>
To: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Cc: Arnaldo Carvalho de Melo <acme@mandriva.com>
Subject: [PATCH] twcal_jiffie should be unsigned long, not int
Date: Mon, 5 Mar 2007 16:09:21 +0100	[thread overview]
Message-ID: <200703051609.21133.dada1@cosmosbay.com> (raw)
In-Reply-To: <200703051528.02564.dada1@cosmosbay.com>

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

Hi David

While browsing include/net/inet_timewait_sock.h, I found this buggy definition 
of twcal_jiffie.

int         twcal_jiffie;

I wonder how inet_twdr_twcal_tick() can really works on x86_64

This seems quite an old bug, it was there before introduction of 
inet_timewait_death_row made by Arnaldo Carvalho de Melo.

[PATCH] twcal_jiffie should be unsigned long, not int

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>


[-- Attachment #2: twcal_jiffie.patch --]
[-- Type: text/plain, Size: 477 bytes --]

diff --git a/include/net/inet_timewait_sock.h b/include/net/inet_timewait_sock.h
index f7be1ac..09a2532 100644
--- a/include/net/inet_timewait_sock.h
+++ b/include/net/inet_timewait_sock.h
@@ -66,7 +66,7 @@ #define INET_TWDR_TWKILL_QUOTA 100
 struct inet_timewait_death_row {
 	/* Short-time timewait calendar */
 	int			twcal_hand;
-	int			twcal_jiffie;
+	unsigned long		twcal_jiffie;
 	struct timer_list	twcal_timer;
 	struct hlist_head	twcal_row[INET_TWDR_RECYCLE_SLOTS];
 

  reply	other threads:[~2007-03-05 15:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <45EBFD13.1060106@symas.com>
2007-03-05 14:28 ` TCP 2MSL on loopback Eric Dumazet
2007-03-05 15:09   ` Eric Dumazet [this message]
2007-03-05 21:33     ` [PATCH] twcal_jiffie should be unsigned long, not int David Miller
2007-03-06  9:22   ` TCP 2MSL on loopback Howard Chu
2007-03-06 10:42     ` Eric Dumazet
2007-03-06 18:39       ` Howard Chu
2007-03-06 20:07         ` Eric Dumazet
2007-03-06 20:28           ` Howard Chu
2007-03-06 20:39             ` Eric Dumazet
2007-03-06 21:05               ` Howard Chu
2007-03-06 21:25                 ` Rick Jones
2007-03-06 21:35                   ` David Miller
2007-03-06 22:07                     ` Howard Chu
2007-03-06 22:54                       ` Stephen Hemminger
2007-03-06 23:22                         ` Howard Chu
2007-03-06 18:04     ` David Miller
2007-03-06 18:46     ` Rick Jones
2007-03-06 19:25       ` Howard Chu
2007-03-06 20:41         ` Rick Jones
2007-03-07  3:36           ` Howard Chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200703051609.21133.dada1@cosmosbay.com \
    --to=dada1@cosmosbay.com \
    --cc=acme@mandriva.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).