From: Don Fry <pcnet32@verizon.net>
To: Jeff Garzik <jeff@garzik.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] pcnet32: only allocate init_block dma consistent
Date: Tue, 6 Mar 2007 10:30:05 -0800 [thread overview]
Message-ID: <20070306183005.GA21731@verizon.net> (raw)
In-Reply-To: <45ED4CCA.7030606@garzik.org>
The change to use netdev_priv can only be done After moving the init
block out of the private structure. It will break the driver if done
first, which is why they were sent together.
I will separate the changes and resend them.
On Tue, Mar 06, 2007 at 06:13:14AM -0500, Jeff Garzik wrote:
> Don Fry wrote:
> >The patch below moves the init_block out of the private struct and
> >only allocates init block with pci_alloc_consistent.
> >
> >This has two effects:
> >
> >1. Performance increase for non cache coherent machines, because the
> > CPU only data in the private struct are now cached
> >
> >2. locks are working now for platforms, which need to have locks
> > in cached memory
> >
> >Also use netdev_priv() instead of dev->priv
> >
> >Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
>
> please separate the netdev_priv() change into a separate, precursor
> patch, and resend both
>
>
prev parent reply other threads:[~2007-03-06 18:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 2:10 [PATCH] pcnet32: only allocate init_block dma consistent Don Fry
2007-03-06 11:13 ` Jeff Garzik
2007-03-06 18:30 ` Don Fry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070306183005.GA21731@verizon.net \
--to=pcnet32@verizon.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).