netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: mitch@linux.vnet.ibm.com, yoshfuji@linux-ipv6.org,
	netdev@vger.kernel.org, usagi-core@linux-ipv6.org
Subject: Re: [PATCH] Ensure IF_READY is unset when link is not ready
Date: Wed, 07 Mar 2007 15:54:38 -0800 (PST)	[thread overview]
Message-ID: <20070307.155438.27784474.davem@davemloft.net> (raw)
In-Reply-To: <E1HP5rQ-0008RW-00@gondolin.me.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 08 Mar 2007 10:47:56 +1100

> Mitsuru Chinen <mitch@linux.vnet.ibm.com> wrote:
> > 
> > On linux-2.6.21-rc2 or later, IPv6 link-local address is not assigned to
> > some kind of interfaces during system start-up. (I found this issue
> > occures with e100, e1000 and tg3.)
> 
> Here is an alternative fix.
> 
> [IPV6]: Do not set IF_READY if device is down
> 
> Now that we add the IPv6 device at registration time we don't need
> to set IF_READY in ipv6_add_dev anymore because we will always get
> a NETDEV_UP event later on should the device ever become ready.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Indeed, this looks like it will do the right thing.

And if you look into the history of the code in this area
I think you'll find that this snippet being removed existed
exactly because inet6_dev creation happened long after the
device was registered.

  reply	other threads:[~2007-03-07 23:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-05  8:59 [PATCH] Ensure IF_READY is unset when link is not ready Mitsuru Chinen
2007-03-07 23:47 ` Herbert Xu
2007-03-07 23:54   ` David Miller [this message]
2007-03-08  2:01     ` Mitsuru Chinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070307.155438.27784474.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=mitch@linux.vnet.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=usagi-core@linux-ipv6.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).