Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: shemminger@linux-foundation.org
Cc: netdev@vger.kernel.org, bridge@linux-foundation.org
Subject: Re: [PATCH] bridge: adding new device to bridge should enable if up
Date: Wed, 07 Mar 2007 16:12:03 -0800 (PST)	[thread overview]
Message-ID: <20070307.161203.26532896.davem@davemloft.net> (raw)
In-Reply-To: <20070307160355.0e27f425@dxpl.pdx.osdl.net>

From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Wed, 7 Mar 2007 16:03:55 -0800

> One change introduced by the workqueue removal patch is that adding an
> interface that is up to a bridge which is also up does not ever call
> br_stp_enable_port(), leaving the port in DISABLED state until we do
> ifconfig down and up or link events occur.
> 
> The following patch to the br_add_if function fixes it.
> This is a regression introduced in 2.6.21.
> 
> Submitted-by: Aji_Srinivas@emc.com
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>

Applied, but:

> +	if ((dev->flags & IFF_UP) && netif_carrier_ok(dev) &&
> +	    (br->dev->flags & IFF_UP)) 

I had to fix up the trailing whitespace on that second line.

Please use "git apply --check --whitespace=error-all"
or similar to validate the patches you send me.

Thanks.

  reply	other threads:[~2007-03-08  0:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-08  0:03 [PATCH] bridge: adding new device to bridge should enable if up Stephen Hemminger
2007-03-08  0:12 ` David Miller [this message]
2007-03-08  3:30 ` brctl issue Hai Wang
2007-03-08 21:14   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070307.161203.26532896.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bridge@linux-foundation.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox