* [PATCH] udp: net-2.6.22 build fix
@ 2007-03-07 21:47 Stephen Hemminger
2007-03-07 21:51 ` Herbert Xu
2007-03-07 22:40 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Hemminger @ 2007-03-07 21:47 UTC (permalink / raw)
To: David S. Miller, Herbert Xu; +Cc: netdev
Recent change broke build of UDP.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
--- net-2.6.22.orig/net/ipv4/udp.c 2007-03-07 13:43:59.000000000 -0800
+++ net-2.6.22/net/ipv4/udp.c 2007-03-07 13:45:43.000000000 -0800
@@ -1283,7 +1283,7 @@
* the network is concerned, anyway) as per 4.1.3.4 (MUST).
*/
LIMIT_NETDEBUG(KERN_DEBUG "UDP%s: bad checksum. From %d.%d.%d.%d:%d to %d.%d.%d.%d:%d ulen %d\n",
- is_udplite? "-Lite" : "",
+ proto == IPPROTO_UDPLITE ? "-Lite" : "",
NIPQUAD(saddr),
ntohs(uh->source),
NIPQUAD(daddr),
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] udp: net-2.6.22 build fix
2007-03-07 21:47 [PATCH] udp: net-2.6.22 build fix Stephen Hemminger
@ 2007-03-07 21:51 ` Herbert Xu
2007-03-07 22:39 ` David Miller
2007-03-07 22:40 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Herbert Xu @ 2007-03-07 21:51 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: David S. Miller, netdev
On Wed, Mar 07, 2007 at 01:47:43PM -0800, Stephen Hemminger wrote:
> Recent change broke build of UDP.
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Thanks for that Stephen. Somehow this one got away. Perhaps we
can recode these macros so that they always get compiled-checked?
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] udp: net-2.6.22 build fix
2007-03-07 21:51 ` Herbert Xu
@ 2007-03-07 22:39 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2007-03-07 22:39 UTC (permalink / raw)
To: herbert; +Cc: shemminger, netdev
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 8 Mar 2007 08:51:48 +1100
> Perhaps we can recode these macros so that they always get
> compiled-checked?
Yes, we really should.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] udp: net-2.6.22 build fix
2007-03-07 21:47 [PATCH] udp: net-2.6.22 build fix Stephen Hemminger
2007-03-07 21:51 ` Herbert Xu
@ 2007-03-07 22:40 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2007-03-07 22:40 UTC (permalink / raw)
To: shemminger; +Cc: herbert, netdev
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Wed, 7 Mar 2007 13:47:43 -0800
> Recent change broke build of UDP.
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Applied, thanks Stephen.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-03-07 22:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-07 21:47 [PATCH] udp: net-2.6.22 build fix Stephen Hemminger
2007-03-07 21:51 ` Herbert Xu
2007-03-07 22:39 ` David Miller
2007-03-07 22:40 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).