From: Don Fry <pcnet32@verizon.net>
To: "Michael K. Edwards" <medwards.linux@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
jgarzik@pobox.com, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] pcnet32: only allocate init_block dma consistent
Date: Wed, 7 Mar 2007 17:44:17 -0800 [thread overview]
Message-ID: <20070308014417.GA11717@verizon.net> (raw)
In-Reply-To: <f2b55d220703071215v4df1bb40had54aa66b7ce1065@mail.gmail.com>
On Wed, Mar 07, 2007 at 12:15:26PM -0800, Michael K. Edwards wrote:
> cacheability of the allocated block. Maybe it doesn't. The alpha
> version of pci_alloc_consistent, on the other hand, does interesting
> things to make the memory visible to PCI. Don, what arches did you
> have in mind when you commented on caching issues?
>
I had not made any comments on the caching issue until now.
The comments on the caching and performance improvements came from
Thomas Bogendoerfer who submitted this change, and Ralf Baechle.
On some architectures, at least for MIPS, the locks have to be in cached
memory. The only part of the data structure that has to be in pci
coherent memory is the init block data structure, which the chip reads.
All the rest of the information in the private structure are for the
driver.
Having those variables in cacheable memory "should" improve performance,
I would think.
Don
next prev parent reply other threads:[~2007-03-08 1:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 18:45 [PATCH 1/2] pcnet32: only allocate init_block dma consistent Don Fry
2007-03-07 3:10 ` Ralf Baechle
2007-03-07 3:39 ` Michael K. Edwards
2007-03-07 4:21 ` Ralf Baechle
2007-03-07 16:35 ` Michael K. Edwards
2007-03-07 19:22 ` Ralf Baechle
2007-03-07 20:15 ` Michael K. Edwards
2007-03-08 1:44 ` Don Fry [this message]
2007-03-07 14:50 ` Lennart Sorensen
2007-03-09 17:01 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070308014417.GA11717@verizon.net \
--to=pcnet32@verizon.net \
--cc=jgarzik@pobox.com \
--cc=medwards.linux@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).