[PATCH][SCTP] Re: lockdep: inconsistent lock state ipv6_add_addr/sctp_v6_copy_addrlist (2.6.21-rc1)

[PATCH][SCTP] Re: lockdep: inconsistent lock state ipv6_add_addr/sctp_v6_copy_addrlist (2.6.21-rc1)

[Jarek Poplawski]

On 25-02-2007 10:08, Simon Arlott wrote:
> This happens on every boot if more information is needed:
> 
> [   37.393715] =================================
> [   37.393830] [ INFO: inconsistent lock state ]
> [   37.393881] 2.6.21-rc1-git #146
> [   37.393929] ---------------------------------
> [   37.393979] inconsistent {softirq-on-R} -> {in-softirq-W} usage.
> [   37.394040] hotplug/1072 [HC0[0]:SC1[2]:HE1:SE0] takes:
> [   37.394092]  (&ndev->lock){-+-?}, at: [<b04a7944>] ipv6_add_addr+0x164/0x1e0
> [   37.394308] {softirq-on-R} state was registered at:
> [   37.394359]   [<b013fc42>] __lock_acquire+0x622/0xbb0
> [   37.394515]   [<b0140652>] lock_acquire+0x62/0x80
> [   37.394678]   [<b0511c65>] _read_lock+0x35/0x50
> [   37.394834]   [<b050e200>] sctp_v6_copy_addrlist+0x30/0xc0
...

[SCTP] ipv6: inconsistent lock state ipv6_add_addr/sctp_v6_copy_addrlist

lockdep found that dev->lock taken from softirq in ipv6_add_addr
is also taken in sctp_v6_copy_addrlist with softirqs enabled, so
lockup is possible.

Noticed-by: Simon Arlott <simon@arlott.org>
Signed-off-by: Jarek Poplawski <jarkao2@o2.pl>

---

diff -Nurp linux-2.6.21-rc2-mm2-/net/sctp/ipv6.c linux-2.6.21-rc2-mm2/net/sctp/ipv6.c
--- linux-2.6.21-rc2-mm2-/net/sctp/ipv6.c	2007-02-21 19:46:49.000000000 +0100
+++ linux-2.6.21-rc2-mm2/net/sctp/ipv6.c	2007-03-07 21:57:37.000000000 +0100
@@ -360,7 +360,7 @@ static void sctp_v6_copy_addrlist(struct
 		return;
 	}
 
-	read_lock(&in6_dev->lock);
+	read_lock_bh(&in6_dev->lock);
 	for (ifp = in6_dev->addr_list; ifp; ifp = ifp->if_next) {
 		/* Add the address to the local list.  */
 		addr = t_new(struct sctp_sockaddr_entry, GFP_ATOMIC);
@@ -374,7 +374,7 @@ static void sctp_v6_copy_addrlist(struct
 		}
 	}
 
-	read_unlock(&in6_dev->lock);
+	read_unlock_bh(&in6_dev->lock);
 	rcu_read_unlock();
 }
 

Re: [PATCH][SCTP] Re: lockdep: inconsistent lock state ipv6_add_addr/sctp_v6_copy_addrlist (2.6.21-rc1)

[Herbert Xu]

Jarek Poplawski <jarkao2@o2.pl> wrote:
> On 25-02-2007 10:08, Simon Arlott wrote:
>> This happens on every boot if more information is needed:
>> 
>> [   37.393715] =================================
>> [   37.393830] [ INFO: inconsistent lock state ]
>> [   37.393881] 2.6.21-rc1-git #146
>> [   37.393929] ---------------------------------
>> [   37.393979] inconsistent {softirq-on-R} -> {in-softirq-W} usage.
>> [   37.394040] hotplug/1072 [HC0[0]:SC1[2]:HE1:SE0] takes:
>> [   37.394092]  (&ndev->lock){-+-?}, at: [<b04a7944>] ipv6_add_addr+0x164/0x1e0
>> [   37.394308] {softirq-on-R} state was registered at:
>> [   37.394359]   [<b013fc42>] __lock_acquire+0x622/0xbb0
>> [   37.394515]   [<b0140652>] lock_acquire+0x62/0x80
>> [   37.394678]   [<b0511c65>] _read_lock+0x35/0x50
>> [   37.394834]   [<b050e200>] sctp_v6_copy_addrlist+0x30/0xc0
> ...
> 
> [SCTP] ipv6: inconsistent lock state ipv6_add_addr/sctp_v6_copy_addrlist
> 
> lockdep found that dev->lock taken from softirq in ipv6_add_addr
> is also taken in sctp_v6_copy_addrlist with softirqs enabled, so
> lockup is possible.

Who's calling ipv6_add_addr from softirq context? That's got to be
wrong because ipv6_add_addr requires the RTNL.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH][SCTP] Re: lockdep: inconsistent lock state ipv6_add_addr/sctp_v6_copy_addrlist (2.6.21-rc1)

[Herbert Xu]

On Thu, Mar 08, 2007 at 10:00:23PM +1100, Herbert Xu wrote:
> 
> Who's calling ipv6_add_addr from softirq context? That's got to be
> wrong because ipv6_add_addr requires the RTNL.

Nevermind, I was thinking of ipv6_add_dev.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH][SCTP] Re: lockdep: inconsistent lock state ipv6_add_addr/sctp_v6_copy_addrlist (2.6.21-rc1)

[Jarek Poplawski]

On Thu, Mar 08, 2007 at 10:02:30PM +1100, Herbert Xu wrote:
> On Thu, Mar 08, 2007 at 10:00:23PM +1100, Herbert Xu wrote:
> > 
> > Who's calling ipv6_add_addr from softirq context? That's got to be
> > wrong because ipv6_add_addr requires the RTNL.
> 
> Nevermind, I was thinking of ipv6_add_dev.

Anyway - maybe I forgot to say - the full error message
available on linux-kernel.

Cheers,
Jarek P.

Re: [PATCH][SCTP] Re: lockdep: inconsistent lock state ipv6_add_addr/sctp_v6_copy_addrlist (2.6.21-rc1)

[David Miller]

From: Jarek Poplawski <jarkao2@o2.pl>
Date: Thu, 8 Mar 2007 08:47:51 +0100

> On 25-02-2007 10:08, Simon Arlott wrote:
> > This happens on every boot if more information is needed:
> > 
> > [   37.393715] =================================
> > [   37.393830] [ INFO: inconsistent lock state ]
> > [   37.393881] 2.6.21-rc1-git #146
> > [   37.393929] ---------------------------------
> > [   37.393979] inconsistent {softirq-on-R} -> {in-softirq-W} usage.
> > [   37.394040] hotplug/1072 [HC0[0]:SC1[2]:HE1:SE0] takes:
> > [   37.394092]  (&ndev->lock){-+-?}, at: [<b04a7944>] ipv6_add_addr+0x164/0x1e0
> > [   37.394308] {softirq-on-R} state was registered at:
> > [   37.394359]   [<b013fc42>] __lock_acquire+0x622/0xbb0
> > [   37.394515]   [<b0140652>] lock_acquire+0x62/0x80
> > [   37.394678]   [<b0511c65>] _read_lock+0x35/0x50
> > [   37.394834]   [<b050e200>] sctp_v6_copy_addrlist+0x30/0xc0
> ...
> 
> [SCTP] ipv6: inconsistent lock state ipv6_add_addr/sctp_v6_copy_addrlist
> 
> lockdep found that dev->lock taken from softirq in ipv6_add_addr
> is also taken in sctp_v6_copy_addrlist with softirqs enabled, so
> lockup is possible.
> 
> Noticed-by: Simon Arlott <simon@arlott.org>
> Signed-off-by: Jarek Poplawski <jarkao2@o2.pl>

Patch applied, thanks Jarek.