Re: [PATCH] Ensure IF_READY is unset when link is not ready

[Mitsuru Chinen <mitch@linux.vnet.ibm.com>]

On Wed, 07 Mar 2007 15:54:38 -0800 (PST)
David Miller <davem@davemloft.net> wrote:

> From: Herbert Xu <herbert@gondor.apana.org.au>
> Date: Thu, 08 Mar 2007 10:47:56 +1100
> 
> > Mitsuru Chinen <mitch@linux.vnet.ibm.com> wrote:
> > > 
> > > On linux-2.6.21-rc2 or later, IPv6 link-local address is not assigned to
> > > some kind of interfaces during system start-up. (I found this issue
> > > occures with e100, e1000 and tg3.)
> > 
> > Here is an alternative fix.
> > 
> > [IPV6]: Do not set IF_READY if device is down
> > 
> > Now that we add the IPv6 device at registration time we don't need
> > to set IF_READY in ipv6_add_dev anymore because we will always get
> > a NETDEV_UP event later on should the device ever become ready.
> > 
> > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> 
> Indeed, this looks like it will do the right thing.
> 
> And if you look into the history of the code in this area
> I think you'll find that this snippet being removed existed
> exactly because inet6_dev creation happened long after the
> device was registered.

I understand. Thanks.
And I thank Herbert to provide suitable fix.

Best Regards,
----
Mitsuru Chinen <mitch@linux.vnet.ibm.com>