SSB/b44 build failure

SSB/b44 build failure

[Randy Dunlap]

Hi,

In 2.6.21-rc3-mm2, with CONFIG_SSB=y but all other SSB kconfig
symbols disabled, I get this (on x86_64):

drivers/built-in.o: In function `b44_init':
b44.c:(.init.text+0x6e04): undefined reference to `ssb_pcihost_register'
b44.c:(.init.text+0x6e2c): undefined reference to `ssb_pcihost_unregister'
drivers/built-in.o: In function `b44_cleanup':
b44.c:(.exit.text+0x63b): undefined reference to `ssb_pcihost_unregister'
make: *** [.tmp_vmlinux1] Error 1

---
~Randy
I don't have time to look into a fix for it.

Re: SSB/b44 build failure

[John W. Linville]

On Fri, Mar 09, 2007 at 07:14:09PM -0800, Randy Dunlap wrote:
> Hi,
> 
> In 2.6.21-rc3-mm2, with CONFIG_SSB=y but all other SSB kconfig
> symbols disabled, I get this (on x86_64):
> 
> drivers/built-in.o: In function `b44_init':
> b44.c:(.init.text+0x6e04): undefined reference to `ssb_pcihost_register'
> b44.c:(.init.text+0x6e2c): undefined reference to `ssb_pcihost_unregister'
> drivers/built-in.o: In function `b44_cleanup':
> b44.c:(.exit.text+0x63b): undefined reference to `ssb_pcihost_unregister'
> make: *** [.tmp_vmlinux1] Error 1

FWIW, this is coming from the port of b44 to use the SSB bus which
I'm carrying in the wireless-dev tree.

SSB (i.e. "Sonics Silicon Backplane") is a bus used in Broadcom SoCs
including the b44 and bcm43xx hardware.  The SSB bus driver and the
b44 port to SSB is being developed by Michael Buesch, the maintainer of
the bcm43xx driver.  I've been carrying the b44 SSB port in my tree for
Michael's convenience.  Just an FYI for those wondering what SSB is...

John

P.S.  How about this patch?

From: John W. Linville <linville@tuxdriver.com>

[PATCH] b44: make B44_PCI select SSB_PCIHOST in drivers/net/Kconfig

Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
 drivers/net/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 6a4325b..b2e1deb 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -1402,6 +1402,7 @@ config B44
 config B44_PCI
 	bool "Broadcom 4400 PCI device support"
 	depends on B44 && NET_PCI
+	select SSB_PCIHOST
 	default y
 	help
 	  Support for b44 PCI devices.
-- 
John W. Linville
linville@tuxdriver.com

Re: SSB/b44 build failure

[Adrian Bunk]

On Sat, Mar 10, 2007 at 10:03:46AM -0500, John W. Linville wrote:
> On Fri, Mar 09, 2007 at 07:14:09PM -0800, Randy Dunlap wrote:
> > Hi,
> > 
> > In 2.6.21-rc3-mm2, with CONFIG_SSB=y but all other SSB kconfig
> > symbols disabled, I get this (on x86_64):
> > 
> > drivers/built-in.o: In function `b44_init':
> > b44.c:(.init.text+0x6e04): undefined reference to `ssb_pcihost_register'
> > b44.c:(.init.text+0x6e2c): undefined reference to `ssb_pcihost_unregister'
> > drivers/built-in.o: In function `b44_cleanup':
> > b44.c:(.exit.text+0x63b): undefined reference to `ssb_pcihost_unregister'
> > make: *** [.tmp_vmlinux1] Error 1
> 
> FWIW, this is coming from the port of b44 to use the SSB bus which
> I'm carrying in the wireless-dev tree.
> 
> SSB (i.e. "Sonics Silicon Backplane") is a bus used in Broadcom SoCs
> including the b44 and bcm43xx hardware.  The SSB bus driver and the
> b44 port to SSB is being developed by Michael Buesch, the maintainer of
> the bcm43xx driver.  I've been carrying the b44 SSB port in my tree for
> Michael's convenience.  Just an FYI for those wondering what SSB is...
> 
> John
> 
> P.S.  How about this patch?
> 
> From: John W. Linville <linville@tuxdriver.com>
> 
> [PATCH] b44: make B44_PCI select SSB_PCIHOST in drivers/net/Kconfig
> 
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
>  drivers/net/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 6a4325b..b2e1deb 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -1402,6 +1402,7 @@ config B44
>  config B44_PCI
>  	bool "Broadcom 4400 PCI device support"
>  	depends on B44 && NET_PCI
> +	select SSB_PCIHOST
>  	default y
>  	help
>  	  Support for b44 PCI devices.


This also requires a depends or select on SSB.


> John W. Linville


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: SSB/b44 build failure

[John W. Linville]

On Sat, Mar 10, 2007 at 04:38:16PM +0100, Adrian Bunk wrote:
> On Sat, Mar 10, 2007 at 10:03:46AM -0500, John W. Linville wrote:

> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > index 6a4325b..b2e1deb 100644
> > --- a/drivers/net/Kconfig
> > +++ b/drivers/net/Kconfig
> > @@ -1402,6 +1402,7 @@ config B44
> >  config B44_PCI
> >  	bool "Broadcom 4400 PCI device support"
> >  	depends on B44 && NET_PCI
> > +	select SSB_PCIHOST
> >  	default y
> >  	help
> >  	  Support for b44 PCI devices.
> 
> 
> This also requires a depends or select on SSB.

It depends on B44, which selects SSB.

John
-- 
John W. Linville
linville@tuxdriver.com

Re: SSB/b44 build failure

[Adrian Bunk]

On Sat, Mar 10, 2007 at 11:22:40AM -0500, John W. Linville wrote:
> On Sat, Mar 10, 2007 at 04:38:16PM +0100, Adrian Bunk wrote:
> > On Sat, Mar 10, 2007 at 10:03:46AM -0500, John W. Linville wrote:
> 
> > > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > > index 6a4325b..b2e1deb 100644
> > > --- a/drivers/net/Kconfig
> > > +++ b/drivers/net/Kconfig
> > > @@ -1402,6 +1402,7 @@ config B44
> > >  config B44_PCI
> > >  	bool "Broadcom 4400 PCI device support"
> > >  	depends on B44 && NET_PCI
> > > +	select SSB_PCIHOST
> > >  	default y
> > >  	help
> > >  	  Support for b44 PCI devices.
> > 
> > 
> > This also requires a depends or select on SSB.
> 
> It depends on B44, which selects SSB.

Oops, you are correct.

> John

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: SSB/b44 build failure

[Michael Buesch]

On Saturday 10 March 2007 16:38, Adrian Bunk wrote:
> On Sat, Mar 10, 2007 at 10:03:46AM -0500, John W. Linville wrote:
> > On Fri, Mar 09, 2007 at 07:14:09PM -0800, Randy Dunlap wrote:
> > > Hi,
> > > 
> > > In 2.6.21-rc3-mm2, with CONFIG_SSB=y but all other SSB kconfig
> > > symbols disabled, I get this (on x86_64):
> > > 
> > > drivers/built-in.o: In function `b44_init':
> > > b44.c:(.init.text+0x6e04): undefined reference to `ssb_pcihost_register'
> > > b44.c:(.init.text+0x6e2c): undefined reference to `ssb_pcihost_unregister'
> > > drivers/built-in.o: In function `b44_cleanup':
> > > b44.c:(.exit.text+0x63b): undefined reference to `ssb_pcihost_unregister'
> > > make: *** [.tmp_vmlinux1] Error 1
> > 
> > FWIW, this is coming from the port of b44 to use the SSB bus which
> > I'm carrying in the wireless-dev tree.
> > 
> > SSB (i.e. "Sonics Silicon Backplane") is a bus used in Broadcom SoCs
> > including the b44 and bcm43xx hardware.  The SSB bus driver and the
> > b44 port to SSB is being developed by Michael Buesch, the maintainer of
> > the bcm43xx driver.  I've been carrying the b44 SSB port in my tree for
> > Michael's convenience.  Just an FYI for those wondering what SSB is...
> > 
> > John
> > 
> > P.S.  How about this patch?
> > 
> > From: John W. Linville <linville@tuxdriver.com>
> > 
> > [PATCH] b44: make B44_PCI select SSB_PCIHOST in drivers/net/Kconfig
> > 
> > Signed-off-by: John W. Linville <linville@tuxdriver.com>
> > ---
> >  drivers/net/Kconfig |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > index 6a4325b..b2e1deb 100644
> > --- a/drivers/net/Kconfig
> > +++ b/drivers/net/Kconfig
> > @@ -1402,6 +1402,7 @@ config B44
> >  config B44_PCI
> >  	bool "Broadcom 4400 PCI device support"
> >  	depends on B44 && NET_PCI
> > +	select SSB_PCIHOST
> >  	default y
> >  	help
> >  	  Support for b44 PCI devices.
> 
> 
> This also requires a depends or select on SSB.

Sorry for this stupid bug. I'm to blame. :)
The SSB config is already selected by B44. B44_PCI is for
adding the PCI support routines.

The following patch is the right one to fix the issue
completely.

Signed-off-by: Michael Buesch <mb@bu3sch.de>


Index: wireless-dev/drivers/net/Kconfig
===================================================================
--- wireless-dev.orig/drivers/net/Kconfig	2007-03-10 18:31:25.000000000 +0100
+++ wireless-dev/drivers/net/Kconfig	2007-03-10 18:32:35.000000000 +0100
@@ -1402,6 +1402,8 @@ config B44
 config B44_PCI
 	bool "Broadcom 4400 PCI device support"
 	depends on B44 && NET_PCI
+	select SSB_PCIHOST
+	select SSB_DRIVER_PCICORE
 	default y
 	help
 	  Support for b44 PCI devices.


-- 
Greetings Michael.

Re: SSB/b44 build failure

[Christoph Hellwig]

On Sat, Mar 10, 2007 at 10:03:46AM -0500, John W. Linville wrote:
> FWIW, this is coming from the port of b44 to use the SSB bus which
> I'm carrying in the wireless-dev tree.
> >
> SSB (i.e. "Sonics Silicon Backplane") is a bus used in Broadcom SoCs
> including the b44 and bcm43xx hardware.  The SSB bus driver and the
> b44 port to SSB is being developed by Michael Buesch, the maintainer of
> the bcm43xx driver.  I've been carrying the b44 SSB port in my tree for
> Michael's convenience.  Just an FYI for those wondering what SSB is...

Btw, what's the reason this is in wireless-dev?  Could we please merge
this code into mainline soonish (aka 2.6.22) instead of interwinding
it with totally unrelated wireless changes?

Re: SSB/b44 build failure

[Michael Buesch]

On Saturday 10 March 2007 19:05, Christoph Hellwig wrote:
> On Sat, Mar 10, 2007 at 10:03:46AM -0500, John W. Linville wrote:
> > FWIW, this is coming from the port of b44 to use the SSB bus which
> > I'm carrying in the wireless-dev tree.
> > >
> > SSB (i.e. "Sonics Silicon Backplane") is a bus used in Broadcom SoCs
> > including the b44 and bcm43xx hardware.  The SSB bus driver and the
> > b44 port to SSB is being developed by Michael Buesch, the maintainer of
> > the bcm43xx driver.  I've been carrying the b44 SSB port in my tree for
> > Michael's convenience.  Just an FYI for those wondering what SSB is...
> 
> Btw, what's the reason this is in wireless-dev?  Could we please merge
> this code into mainline soonish (aka 2.6.22) instead of interwinding
> it with totally unrelated wireless changes?

nono, don't. SSB is still in heavy development and this would
slow it down by magnitudes.
The reason it's in wireless-dev is, because b44-ssb is simply just
a "sideeffect" of ssb. ssb is mainly written for bcm43xx. That
b44 also has a ssb bus is cool, so it can re-use the code. But
there's _no_ reason to get ssb mainline without bcm43xx going
mainline, too. b44-mainline does not depend on ssb. Current mainline
has the ssb code built into b44. The b44 port in wireless-dev just rips
that code out and uses the ssb subsystem (so it also adds
a few features to b44. For example the ability to dump and write
the EEPROM).

It's really helpful to have the development of b44-ssb in
wireless-dev, because there still are heavy changes in ssb.
Being required to merge a ssb change through mainline before
I can implement a new feature (or fix a bug) in bcm43xx-dev is just
not acceptable.

The _final_ merging is another story. I think a few days before
wireless-dev is merged mainline ssb and b44-ssb should be merged
mainline seperately. Just to make it clear that these are not
wireless related. (ssb is not wireless related, too. Strictly said).

Short: "totally unrelated wireless changes" is a false statement ;)

-- 
Greetings Michael.