From: Jarek Poplawski <jarkao2@o2.pl>
To: David Miller <davem@davemloft.net>
Cc: amit2030@gmail.com, linux-kernel@vger.kernel.org, akpm@osdl.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.
Date: Mon, 12 Mar 2007 12:51:37 +0100 [thread overview]
Message-ID: <20070312115137.GA3270@ff.dom.local> (raw)
In-Reply-To: <20070308.232908.92582631.davem@davemloft.net>
On 09-03-2007 08:29, David Miller wrote:
> From: Amit Choudhary <amit2030@gmail.com>
> Date: Thu, 8 Mar 2007 23:22:15 -0800
>
>> Description: Check the return value of kmalloc() in function wrandom_set_nhinfo(), in file net/ipv4/multipath_wrandom.c.
>>
>> Signed-off-by: Amit Choudhary <amit2030@gmail.com>
>
> This kind of patch has been submitted several times before and it's
> never accepted because you have to do much more than this to recover
> from the allocation error.
>
> There is no error status returned to the caller, so the callers assume
> the operation succeeded, and will either OOPS or crash in some other
> way.
>
> Therefore, just adding some NULL pointer checks and returning is not
> going to fix this bug.
>
> The whole cahce-multipath subsystem has to have it's guts revamped for
> proper error handling.
But until then it'll unnecessarily spoil linux opinion as regards
stability and waste time of developers to check error messages.
So, maybe it's less evil to check those NULLs where possible and add
some WARN_ONs here and there...
Regards,
Jarek P.
next prev parent reply other threads:[~2007-03-12 11:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-09 7:22 [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value Amit Choudhary
2007-03-09 7:29 ` David Miller
2007-03-12 11:51 ` Jarek Poplawski [this message]
2007-03-12 12:36 ` Pekka Enberg
2007-03-12 13:42 ` Jarek Poplawski
2007-03-12 20:54 ` David Miller
2007-03-12 20:53 ` Removal of multipath cached (was Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.) David Miller
2007-03-13 6:22 ` Andrew Morton
2007-03-13 7:05 ` Jarek Poplawski
-- strict thread matches above, loose matches on Subject: below --
2007-03-12 12:15 [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value Pekka J Enberg
2007-03-12 20:56 ` David Miller
2007-03-14 20:15 ` Ravikiran G Thirumalai
2007-03-14 22:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070312115137.GA3270@ff.dom.local \
--to=jarkao2@o2.pl \
--cc=akpm@osdl.org \
--cc=amit2030@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).