From: Jarek Poplawski <jarkao2@o2.pl>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: David Miller <davem@davemloft.net>,
amit2030@gmail.com, linux-kernel@vger.kernel.org, akpm@osdl.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.
Date: Mon, 12 Mar 2007 14:42:31 +0100 [thread overview]
Message-ID: <20070312134230.GD3270@ff.dom.local> (raw)
In-Reply-To: <84144f020703120536l3967dc76o6a130edc79762350@mail.gmail.com>
On Mon, Mar 12, 2007 at 02:36:46PM +0200, Pekka Enberg wrote:
> On 3/12/07, Jarek Poplawski <jarkao2@o2.pl> wrote:
> >So, maybe it's less evil to check those NULLs where possible and add
> >some WARN_ONs here and there...
>
> No, it's much better to oops rather than paper over a bug.
>
I'm not sure I can understand your intentions - do you mean
always better? In my opinion oops is right only to avoid
some danger. And here is no danger - some routing info,
which is internal multipath_xxx data and can be handled
safely, will not go into its cache.
Jarek P.
next prev parent reply other threads:[~2007-03-12 13:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-09 7:22 [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value Amit Choudhary
2007-03-09 7:29 ` David Miller
2007-03-12 11:51 ` Jarek Poplawski
2007-03-12 12:36 ` Pekka Enberg
2007-03-12 13:42 ` Jarek Poplawski [this message]
2007-03-12 20:54 ` David Miller
2007-03-12 20:53 ` Removal of multipath cached (was Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.) David Miller
2007-03-13 6:22 ` Andrew Morton
2007-03-13 7:05 ` Jarek Poplawski
-- strict thread matches above, loose matches on Subject: below --
2007-03-12 12:15 [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value Pekka J Enberg
2007-03-12 20:56 ` David Miller
2007-03-14 20:15 ` Ravikiran G Thirumalai
2007-03-14 22:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070312134230.GD3270@ff.dom.local \
--to=jarkao2@o2.pl \
--cc=akpm@osdl.org \
--cc=amit2030@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).