From: Stephen Hemminger <shemminger@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [patch 4/4] tcp: statistics not read_mostly
Date: Mon, 12 Mar 2007 14:26:47 -0700 [thread overview]
Message-ID: <20070312142647.57038d85@freekitty> (raw)
In-Reply-To: <20070312.141550.48806100.davem@davemloft.net>
On Mon, 12 Mar 2007 14:15:50 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <shemminger@linux-foundation.org>
> Date: Mon, 12 Mar 2007 14:08:21 -0700
>
> > The TCP statistics shouldn't be located in the middle of the
> > read_mostly section surrounded by sysctl values.
> > Move EXPORT_SYMBOL next to data like other declarations near by.
> >
> > Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
>
> Stephen, they are pointers to the statistics, not the statistic
> counters themselves. We're marking the _pointers_ as __read_mostly
> here.
>
> When Eric originally submitted the change to add __read_mostly here I
> didn't understand it either.
>
> Look at the definition of DEFINE_SNMP_STAT().
Okay, that's confusing. And maybe the comment suggests future work:
/*
* FIXME: On x86 and some other CPUs the split into user and softirq parts
* is not needed because addl $1,memory is atomic against interrupts (but
* atomic_inc would be overkill because of the lock cycles). Wants new
* nonlocked_atomic_inc() primitives -AK
*/
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-03-12 21:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 21:08 [patch 0/4] more stuff for 2.6.22 Stephen Hemminger
2007-03-12 21:08 ` [patch 1/4] network dev read_mostly Stephen Hemminger
2007-03-12 21:34 ` David Miller
2007-03-13 5:37 ` Eric Dumazet
2007-03-13 21:26 ` [RFC] Get rid of netdev_nit Stephen Hemminger
2007-04-21 0:02 ` David Miller
2007-03-15 2:18 ` [patch 1/4] network dev read_mostly Benjamin LaHaise
2007-03-15 4:54 ` David Miller
2007-03-15 6:28 ` Eric Dumazet
2007-03-15 7:25 ` David Miller
2007-03-15 7:42 ` Eric Dumazet
2007-03-15 13:17 ` Benjamin LaHaise
2007-03-16 17:03 ` Stephen Hemminger
2007-03-15 15:10 ` Andi Kleen
2007-03-12 21:08 ` [patch 2/4] net: make seq_operations const Stephen Hemminger
2007-03-12 21:34 ` David Miller
2007-03-12 21:08 ` [patch 3/4] net: show bound packet types Stephen Hemminger
2007-03-12 21:35 ` David Miller
2007-03-12 21:08 ` [patch 4/4] tcp: statistics not read_mostly Stephen Hemminger
2007-03-12 21:15 ` David Miller
2007-03-12 21:26 ` Stephen Hemminger [this message]
2007-03-12 21:33 ` David Miller
2007-03-13 20:09 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070312142647.57038d85@freekitty \
--to=shemminger@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).