From: Valerie Henson <val_henson@linux.intel.com>
To: Jeff Garzik <jeff@garzik.org>, akpm@osdl.org
Cc: netdev@vger.kernel.org, Val Henson <val_henson@linux.intel.com>,
Grant Grundler <grundler@parisc-linux.org>
Subject: [patch 4/6] [TULIP] Quiet down tulip_stop_rxtx
Date: Mon, 12 Mar 2007 02:31:32 -0700 [thread overview]
Message-ID: <20070312184218.317747000@linux.intel.com> (raw)
In-Reply-To: 20070312093128.577087000@linux.intel.com
[-- Attachment #1: tulip-quiet-stop-rxtx --]
[-- Type: text/plain, Size: 905 bytes --]
Only print out debugging info for tulip_stop_rxtx if debug is on.
Many cards (including at least two of my own) fail to stop properly
during initialization according to this test with no apparent ill
effects. Worse, it tends to spam logs when the driver doesn't work.
Signed-off-by: Val Henson <val_henson@linux.intel.com>
Signed-off-by: Grant Grundler <grundler@parisc-linux.org>
Cc: Jeff Garzik <jeff@garzik.org>
---
drivers/net/tulip/tulip.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- pristine-linux.orig/drivers/net/tulip/tulip.h
+++ pristine-linux/drivers/net/tulip/tulip.h
@@ -481,7 +481,7 @@ static inline void tulip_stop_rxtx(struc
while (--i && (ioread32(ioaddr + CSR5) & (CSR5_TS|CSR5_RS)))
udelay(10);
- if (!i)
+ if (!i && (tulip_debug > 1))
printk(KERN_DEBUG "%s: tulip_stop_rxtx() failed"
" (CSR5 0x%x CSR6 0x%x)\n",
pci_name(tp->pdev),
--
next prev parent reply other threads:[~2007-03-12 18:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 9:59 [patch 0/4] [TULIP] Tulip updates Valerie Henson
2007-03-12 9:31 ` [patch 1/6] [TULIP] From: Jim Gifford <maillist@jg555.com>, Grant Grundler <grundler@parisc-linux.org>, Peter Horton <pdh@colonel-panic.org> Valerie Henson
2007-03-15 15:20 ` Jeff Garzik
2007-03-12 9:31 ` [patch 2/6] [TULIP] From: Thibaut VARENE <T-Bone@parisc-linux.org> Valerie Henson
2007-03-12 9:31 ` [patch 3/6] [TULIP] fix for Lite-On 82c168 PNIC Valerie Henson
2007-03-15 15:21 ` Jeff Garzik
2007-03-12 9:31 ` Valerie Henson [this message]
2007-03-15 15:25 ` [patch 4/6] [TULIP] Quiet down tulip_stop_rxtx Jeff Garzik
2007-03-16 0:10 ` Valerie Henson
2007-03-17 19:05 ` Grant Grundler
2007-03-12 9:31 ` [patch 5/6] [TULIP] Fix SytemError typo Valerie Henson
2007-03-15 15:29 ` Jeff Garzik
2007-03-12 9:31 ` [patch 6/6] [TULIP] Rev tulip version Valerie Henson
2007-03-12 9:59 ` [patch 1/4] [TULIP] fix for Lite-On 82c168 PNIC Valerie Henson
2007-03-15 12:40 ` Mikael Pettersson
2007-03-12 9:59 ` [patch 2/4] [TULIP] Quiet down tulip_stop_rxtx Valerie Henson
2007-03-12 9:59 ` [patch 3/4] [TULIP] Fix SytemError typo Valerie Henson
2007-03-12 9:59 ` [patch 4/4] [TULIP] Rev tulip version Valerie Henson
2007-03-12 10:44 ` Pekka Enberg
2007-03-12 14:07 ` Jeff Garzik
2007-03-13 17:07 ` Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070312184218.317747000@linux.intel.com \
--to=val_henson@linux.intel.com \
--cc=akpm@osdl.org \
--cc=grundler@parisc-linux.org \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).