From mboxrd@z Thu Jan 1 00:00:00 1970 From: Valerie Henson Subject: [patch 4/6] [TULIP] Quiet down tulip_stop_rxtx Date: Mon, 12 Mar 2007 02:31:32 -0700 Message-ID: <20070312184218.317747000@linux.intel.com> References: <20070312093128.577087000@linux.intel.com> Cc: netdev@vger.kernel.org, Val Henson , Grant Grundler To: Jeff Garzik , akpm@osdl.org Return-path: Received: from mga06.intel.com ([134.134.136.21]:36367 "EHLO orsmga101.jf.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751594AbXCLSmP (ORCPT ); Mon, 12 Mar 2007 14:42:15 -0400 Content-Disposition: inline; filename=tulip-quiet-stop-rxtx Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Only print out debugging info for tulip_stop_rxtx if debug is on. Many cards (including at least two of my own) fail to stop properly during initialization according to this test with no apparent ill effects. Worse, it tends to spam logs when the driver doesn't work. Signed-off-by: Val Henson Signed-off-by: Grant Grundler Cc: Jeff Garzik --- drivers/net/tulip/tulip.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- pristine-linux.orig/drivers/net/tulip/tulip.h +++ pristine-linux/drivers/net/tulip/tulip.h @@ -481,7 +481,7 @@ static inline void tulip_stop_rxtx(struc while (--i && (ioread32(ioaddr + CSR5) & (CSR5_TS|CSR5_RS))) udelay(10); - if (!i) + if (!i && (tulip_debug > 1)) printk(KERN_DEBUG "%s: tulip_stop_rxtx() failed" " (CSR5 0x%x CSR6 0x%x)\n", pci_name(tp->pdev), --