From: Stephen Hemminger <shemminger@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [patch 4/4] tcp: statistics not read_mostly
Date: Mon, 12 Mar 2007 14:08:21 -0700 [thread overview]
Message-ID: <20070312210907.925541692@linux-foundation.org> (raw)
In-Reply-To: 20070312210817.485320783@linux-foundation.org
[-- Attachment #1: tcp_stats-not-mostly --]
[-- Type: text/plain, Size: 948 bytes --]
The TCP statistics shouldn't be located in the middle of the
read_mostly section surrounded by sysctl values.
Move EXPORT_SYMBOL next to data like other declarations near by.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
---
net/ipv4/tcp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- net-2.6.22.orig/net/ipv4/tcp.c 2007-03-12 14:05:26.000000000 -0700
+++ net-2.6.22/net/ipv4/tcp.c 2007-03-12 14:06:08.000000000 -0700
@@ -271,7 +271,8 @@
int sysctl_tcp_fin_timeout __read_mostly = TCP_FIN_TIMEOUT;
-DEFINE_SNMP_STAT(struct tcp_mib, tcp_statistics) __read_mostly;
+DEFINE_SNMP_STAT(struct tcp_mib, tcp_statistics);
+EXPORT_SYMBOL(tcp_statistics);
atomic_t tcp_orphan_count = ATOMIC_INIT(0);
@@ -2492,4 +2493,3 @@
EXPORT_SYMBOL(tcp_sendpage);
EXPORT_SYMBOL(tcp_setsockopt);
EXPORT_SYMBOL(tcp_shutdown);
-EXPORT_SYMBOL(tcp_statistics);
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-03-12 21:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 21:08 [patch 0/4] more stuff for 2.6.22 Stephen Hemminger
2007-03-12 21:08 ` [patch 1/4] network dev read_mostly Stephen Hemminger
2007-03-12 21:34 ` David Miller
2007-03-13 5:37 ` Eric Dumazet
2007-03-13 21:26 ` [RFC] Get rid of netdev_nit Stephen Hemminger
2007-04-21 0:02 ` David Miller
2007-03-15 2:18 ` [patch 1/4] network dev read_mostly Benjamin LaHaise
2007-03-15 4:54 ` David Miller
2007-03-15 6:28 ` Eric Dumazet
2007-03-15 7:25 ` David Miller
2007-03-15 7:42 ` Eric Dumazet
2007-03-15 13:17 ` Benjamin LaHaise
2007-03-16 17:03 ` Stephen Hemminger
2007-03-15 15:10 ` Andi Kleen
2007-03-12 21:08 ` [patch 2/4] net: make seq_operations const Stephen Hemminger
2007-03-12 21:34 ` David Miller
2007-03-12 21:08 ` [patch 3/4] net: show bound packet types Stephen Hemminger
2007-03-12 21:35 ` David Miller
2007-03-12 21:08 ` Stephen Hemminger [this message]
2007-03-12 21:15 ` [patch 4/4] tcp: statistics not read_mostly David Miller
2007-03-12 21:26 ` Stephen Hemminger
2007-03-12 21:33 ` David Miller
2007-03-13 20:09 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070312210907.925541692@linux-foundation.org \
--to=shemminger@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).