From: Andrew Morton <akpm@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: jarkao2@o2.pl, amit2030@gmail.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: Removal of multipath cached (was Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.)
Date: Mon, 12 Mar 2007 22:22:36 -0800 [thread overview]
Message-ID: <20070312222236.860fc180.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070312.135311.71086996.davem@davemloft.net>
> On Mon, 12 Mar 2007 13:53:11 -0700 (PDT) David Miller <davem@davemloft.net> wrote:
> From: Jarek Poplawski <jarkao2@o2.pl>
> Date: Mon, 12 Mar 2007 12:51:37 +0100
>
> > But until then it'll unnecessarily spoil linux opinion as regards
> > stability and waste time of developers to check error messages.
> > So, maybe it's less evil to check those NULLs where possible and add
> > some WARN_ONs here and there...
>
> It's a crash either way, so zero improvement.
>
> And _THIS_ is my big problem with the multi-path cached code in the
> kernel.
>
> NOBODY wants to step up and fix the code, but people refuse to let it
> get removed from the tree. That is totally unacceptable, so I'm going
> to FIX THIS.
>
> I'm going to FIX IT by saying that if nobody steps up to the plate to
> fix the multipath cached code by 2.6.23 IT IS GONE forver.
>
> And there is absolutely no negotiations about this, I've held back on
> this for nearly 2 years, and nothing has happened, this code is not
> maintained, nobody cares enough to fix the bugs, and even no
> distributions enable it because it causes crashes.
Good stuff.
I suggest you put a big printk explaining the above into 2.6.21.
next prev parent reply other threads:[~2007-03-13 5:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-09 7:22 [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value Amit Choudhary
2007-03-09 7:29 ` David Miller
2007-03-12 11:51 ` Jarek Poplawski
2007-03-12 12:36 ` Pekka Enberg
2007-03-12 13:42 ` Jarek Poplawski
2007-03-12 20:54 ` David Miller
2007-03-12 20:53 ` Removal of multipath cached (was Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.) David Miller
2007-03-13 6:22 ` Andrew Morton [this message]
2007-03-13 7:05 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070312222236.860fc180.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=amit2030@gmail.com \
--cc=davem@davemloft.net \
--cc=jarkao2@o2.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).