netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sam@synack.fr
Cc: netdev@vger.kernel.org
Subject: Re: [RFC] [PATCH] Network Events Connector
Date: Wed, 14 Mar 2007 18:17:51 -0700 (PDT)	[thread overview]
Message-ID: <20070314.181751.41635171.davem@davemloft.net> (raw)
In-Reply-To: <m2fy875n9q.fsf@cerbere.dyndns.info>

From: Samir Bellabes <sam@synack.fr>
Date: Thu, 15 Mar 2007 02:05:53 +0100

> +#if 0
> +#define DEBUGP printk
> +#else
> +#define DEBUGP(format, args...)
> +#endif

Please no local debugging macros.

> +static unsigned int is_same_event(struct event one, struct event two) {

Please format functions properly, especially wrt. braces, they don't
belong on the line holding the argument list closing parenthesis:

return_type func_name(args)
{
}

I'm not going to read this any further, please master
Documentation/CodingStyle and resubmit if you want further
review from me.

Thanks.

  reply	other threads:[~2007-03-15  1:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-15  1:05 [RFC] [PATCH] Network Events Connector Samir Bellabes
2007-03-15  1:17 ` David Miller [this message]
2007-03-15 18:00 ` Evgeniy Polyakov
  -- strict thread matches above, loose matches on Subject: below --
2007-02-09  4:43 Samir Bellabes
2007-02-17 16:34 ` Evgeniy Polyakov
2007-03-15  0:48   ` Samir Bellabes
2007-03-15  0:50   ` Samir Bellabes
2007-03-15  0:53   ` Samir Bellabes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070314.181751.41635171.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=sam@synack.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).