From: Alex Sidorenko <alexandre.sidorenko@hp.com>
To: John Heffner <jheffner@psc.edu>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: SWS for rcvbuf < MTU
Date: Wed, 14 Mar 2007 12:18:56 -0400 [thread overview]
Message-ID: <200703141218.57179.alexandre.sidorenko@hp.com> (raw)
In-Reply-To: <45F6F51E.6090905@psc.edu>
On March 13, 2007 03:01:50 pm John Heffner wrote:
> Sorry for the long delay in response, I've been on vacation. I'm okay
> with your patch, and I can't think of any real problem with it, except
> that the behavior is non-standard. Then again, Linux acking in general
> is non-standard, which has created the bug in the first place. :) The
> only thing I can think where it might still ack too often is if
> free_space frequently drops just below full_space/2 for a bit then rises
> above full_space/2.
>
> I've also attached a corrected version of my earlier patch that I think
> solves the problem you noted.
Hello John,
I think your corrected version should avoid the problem I mentioned, but I
will still ask the customer to test the new version. It will be interesting
to compare traffic patterns with those observed with stock kernel and my
earlier patch.
It might take some time to do proper testing, I'll inform you as soon as there
are any results.
Thanks,
Alex
--
------------------------------------------------------------------
Alexandre Sidorenko email: alexs@hplinux.canada.hp.com
Global Solutions Engineering: Unix Networking
Hewlett-Packard (Canada)
------------------------------------------------------------------
next prev parent reply other threads:[~2007-03-14 16:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-02 16:28 SWS for rcvbuf < MTU Alex Sidorenko
2007-03-02 18:54 ` John Heffner
2007-03-02 20:29 ` Alex Sidorenko
2007-03-02 19:25 ` David Miller
2007-03-02 20:21 ` Alex Sidorenko
2007-03-02 20:33 ` David Miller
2007-03-02 21:16 ` John Heffner
2007-03-02 21:38 ` David Miller
2007-03-03 23:40 ` John Heffner
2007-03-05 16:52 ` Alex Sidorenko
2007-03-13 19:01 ` John Heffner
2007-03-14 16:18 ` Alex Sidorenko [this message]
2007-04-02 20:01 ` Alex Sidorenko
2007-04-02 20:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703141218.57179.alexandre.sidorenko@hp.com \
--to=alexandre.sidorenko@hp.com \
--cc=davem@davemloft.net \
--cc=jheffner@psc.edu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).