From: Ravikiran G Thirumalai <kiran@scalex86.org>
To: David Miller <davem@davemloft.net>
Cc: penberg@cs.helsinki.fi, amit2030@gmail.com,
linux-kernel@vger.kernel.org, akpm@osdl.org,
netdev@vger.kernel.org, shai@scalex86.org,
pravin b shelar <pravin.shelar@calsoftinc.com>,
"Benzi Galili (Benzi@ScaleMP.com)" <benzi@scalemp.com>
Subject: Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.
Date: Wed, 14 Mar 2007 13:15:42 -0700 [thread overview]
Message-ID: <20070314201542.GA4192@localhost.localdomain> (raw)
In-Reply-To: <20070312.135613.78710501.davem@davemloft.net>
On Mon, Mar 12, 2007 at 01:56:13PM -0700, David Miller wrote:
> From: Pekka J Enberg <penberg@cs.helsinki.fi>
> Date: Mon, 12 Mar 2007 14:15:16 +0200 (EET)
>
> > On 3/9/07, David Miller <davem@davemloft.net> wrote:
> > > The whole cahce-multipath subsystem has to have it's guts revamped for
> > > proper error handling.
> >
> > (Untested patch follows.)
>
> I'm not accepting untested patches, if people want to fix this
> code it cannot be done in a shoddy manner any more, it will
> need to be fixed and tested by people who really care about
> this code.
Hi Dave,
We do care for multipath cached option. We do use it often with node
aware multipath. We haven't experienced oopsen or crashes for our use cases
since the past year. We will test Amit and Pekka's patch with fault injection.
We will also go through the core multipath-cached code and give a try at
cleaning it up.
>
> We need real care for this code or I will remove it in 2.6.23
Can you please point us to any open bug reports on multipath cached? We did
a Call for testing on netdev sometime back but did not get any bug reports.
http://marc.info/?l=linux-netdev&m=114827370231872&w=2
The kernel bugzilla shows zaroo boogs for multipath cached as well.
Thanks,
Kiran
next prev parent reply other threads:[~2007-03-14 21:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 12:15 [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value Pekka J Enberg
2007-03-12 20:56 ` David Miller
2007-03-14 20:15 ` Ravikiran G Thirumalai [this message]
2007-03-14 22:11 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2007-03-09 7:22 Amit Choudhary
2007-03-09 7:29 ` David Miller
2007-03-12 11:51 ` Jarek Poplawski
2007-03-12 12:36 ` Pekka Enberg
2007-03-12 13:42 ` Jarek Poplawski
2007-03-12 20:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070314201542.GA4192@localhost.localdomain \
--to=kiran@scalex86.org \
--cc=akpm@osdl.org \
--cc=amit2030@gmail.com \
--cc=benzi@scalemp.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=pravin.shelar@calsoftinc.com \
--cc=shai@scalex86.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).