From: Jarek Poplawski <jarkao2@o2.pl>
To: Patrick McHardy <kaber@trash.net>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Robert.Olsson@data.slu.se, tgr@suug.ch
Subject: Re: fib_hash removal
Date: Thu, 15 Mar 2007 10:15:44 +0100 [thread overview]
Message-ID: <20070315091544.GB1671@ff.dom.local> (raw)
In-Reply-To: <45F8F93F.6010408@trash.net>
On Thu, Mar 15, 2007 at 08:43:59AM +0100, Patrick McHardy wrote:
...
> > On 14-03-2007 23:49, Patrick McHardy wrote:
...
> >>BUG: sleeping function called from invalid context at mm/slab.c:3032
> >>in_atomic():1, irqs_disabled():0
...
> Yes, Robert already sent me a patch to remove the bogus preempt_disable,
> but IIRC it was there to make sure changes to the tree don't interfere
> with packet processing, so we might need to do something else. I'll try
> to look into it later today.
>
BTW: it seems fib_tree wasn't used too much, so probably,
before killing fib_hash, fib_tree should be made Kconfig
default for some time.
Jarek P.
next prev parent reply other threads:[~2007-03-15 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 22:44 fib_hash removal David Miller
2007-03-14 22:49 ` Patrick McHardy
2007-03-15 7:40 ` Jarek Poplawski
2007-03-15 7:43 ` Patrick McHardy
2007-03-15 9:15 ` Jarek Poplawski [this message]
2007-03-15 9:23 ` Jarek Poplawski
2007-03-15 9:42 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070315091544.GB1671@ff.dom.local \
--to=jarkao2@o2.pl \
--cc=Robert.Olsson@data.slu.se \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=tgr@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).