From: Valerie Henson <val_henson@linux.intel.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: akpm@osdl.org, netdev@vger.kernel.org,
Grant Grundler <grundler@parisc-linux.org>
Subject: Re: [patch 4/6] [TULIP] Quiet down tulip_stop_rxtx
Date: Thu, 15 Mar 2007 17:10:10 -0700 [thread overview]
Message-ID: <20070316001010.GE5291@nifty> (raw)
In-Reply-To: <45F96556.10205@garzik.org>
On Thu, Mar 15, 2007 at 11:25:10AM -0400, Jeff Garzik wrote:
>
> Here's the problem with this: this printk is signalling that the DMA
> engines have not yet stopped, which is an event of which we should be wary.
>
> While it makes sense to do this patch, since the complaining cards
> appear to work anyway, we also need to take into account the times when
> this is not a spurious warning.
>
> Thus, I would consider maybe adding a warning somewhere in the
> DMA-engine-start region of code, that complains if the DMA engines are
> already active, or somesuch.
Yeah, I agree it's signifying a problem, and we should have a warning
(only one) until we figure out what's going on. Put on my to-do list.
-VAL
next prev parent reply other threads:[~2007-03-16 0:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 9:59 [patch 0/4] [TULIP] Tulip updates Valerie Henson
2007-03-12 9:31 ` [patch 1/6] [TULIP] From: Jim Gifford <maillist@jg555.com>, Grant Grundler <grundler@parisc-linux.org>, Peter Horton <pdh@colonel-panic.org> Valerie Henson
2007-03-15 15:20 ` Jeff Garzik
2007-03-12 9:31 ` [patch 2/6] [TULIP] From: Thibaut VARENE <T-Bone@parisc-linux.org> Valerie Henson
2007-03-12 9:31 ` [patch 3/6] [TULIP] fix for Lite-On 82c168 PNIC Valerie Henson
2007-03-15 15:21 ` Jeff Garzik
2007-03-12 9:31 ` [patch 4/6] [TULIP] Quiet down tulip_stop_rxtx Valerie Henson
2007-03-15 15:25 ` Jeff Garzik
2007-03-16 0:10 ` Valerie Henson [this message]
2007-03-17 19:05 ` Grant Grundler
2007-03-12 9:31 ` [patch 5/6] [TULIP] Fix SytemError typo Valerie Henson
2007-03-15 15:29 ` Jeff Garzik
2007-03-12 9:31 ` [patch 6/6] [TULIP] Rev tulip version Valerie Henson
2007-03-12 9:59 ` [patch 1/4] [TULIP] fix for Lite-On 82c168 PNIC Valerie Henson
2007-03-15 12:40 ` Mikael Pettersson
2007-03-12 9:59 ` [patch 2/4] [TULIP] Quiet down tulip_stop_rxtx Valerie Henson
2007-03-12 9:59 ` [patch 3/4] [TULIP] Fix SytemError typo Valerie Henson
2007-03-12 9:59 ` [patch 4/4] [TULIP] Rev tulip version Valerie Henson
2007-03-12 10:44 ` Pekka Enberg
2007-03-12 14:07 ` Jeff Garzik
2007-03-13 17:07 ` Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070316001010.GE5291@nifty \
--to=val_henson@linux.intel.com \
--cc=akpm@osdl.org \
--cc=grundler@parisc-linux.org \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).