From: linas@austin.ibm.com (Linas Vepstas)
To: Ramkrishna Vepa <Ramkrishna.Vepa@neterion.com>
Cc: Wen Xiong <wenxiong@us.ibm.com>,
linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
netdev@vger.kernel.org, Jeff Garzik <jgarzik@pobox.com>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] s2io: add PCI error recovery support
Date: Fri, 16 Mar 2007 14:49:41 -0500 [thread overview]
Message-ID: <20070316194941.GP5151@austin.ibm.com> (raw)
In-Reply-To: <78C9135A3D2ECE4B8162EBDCE82CAD7701481EE3@nekter>
On Mon, Mar 05, 2007 at 05:33:39PM -0500, Ramkrishna Vepa wrote:
> Comments on this patch -
>
> 1. device_close_flag is unused and is not required.
I'll submit a patch to strip this out sometime next week.
> 2. s2io_reset can fail to reset the device.
I thought I'd seen this occasionally, and its on my to-do list
to look into this further.
> Ideally s2io_reset should
> return a failure in this case (return is void now)
Would you care to provide a patch that did this? I could
experiment a bit, and try to do this myself; but I really
don't know this hardware, or this driver, that well.
--linas
next prev parent reply other threads:[~2007-03-16 19:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-05 22:33 [PATCH] s2io: add PCI error recovery support Ramkrishna Vepa
2007-03-16 19:49 ` Linas Vepstas [this message]
2007-03-16 19:58 ` Ramkrishna Vepa
-- strict thread matches above, loose matches on Subject: below --
2007-03-07 0:42 Ramkrishna Vepa
2007-02-15 23:08 Linas Vepstas
2006-10-27 11:35 Ananda Raju
2006-10-27 19:32 ` Linas Vepstas
2006-10-26 9:56 Ananda Raju
2006-10-26 22:51 ` Linas Vepstas
2006-10-25 6:29 Ananda Raju
2006-10-25 15:11 ` Linas Vepstas
2006-10-25 20:55 ` Linas Vepstas
2006-10-24 21:54 Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070316194941.GP5151@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=Ramkrishna.Vepa@neterion.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=netdev@vger.kernel.org \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).