From: Matt Mackall <mpm@selenic.com>
To: Keiichi KII <k-keiichi@bx.jp.nec.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC][PATCH -mm take3 1/6][resend] marking __init
Date: Tue, 20 Mar 2007 10:36:27 -0500 [thread overview]
Message-ID: <20070320153627.GF4892@waste.org> (raw)
In-Reply-To: <45FFD272.6020105@bx.jp.nec.com>
On Tue, Mar 20, 2007 at 09:24:18PM +0900, Keiichi KII wrote:
> From: Keiichi KII <k-keiichi@bx.jp.nec.com>
>
> This patch contains the following cleanups.
> - add __init for initialization functions(option_setup() and
> init_netconsole()).
>
> Signed-off-by: Keiichi KII <k-keiichi@bx.jp.nec.com>
> Signed-off-by: Takayoshi Kochi <t-kochi@bq.jp.nec.com>
> ---
> Index: linux-mm/drivers/net/netconsole.c
> ===================================================================
> --- linux-mm.orig/drivers/net/netconsole.c
> +++ linux-mm/drivers/net/netconsole.c
> @@ -91,7 +91,7 @@ static struct console netconsole = {
> .write = write_msg
> };
>
> -static int option_setup(char *opt)
> +static int __init option_setup(char *opt)
> {
> configured = !netpoll_parse_options(&np, opt);
> return 1;
> @@ -99,7 +99,7 @@ static int option_setup(char *opt)
>
> __setup("netconsole=", option_setup);
>
> -static int init_netconsole(void)
> +static int __init init_netconsole(void)
> {
> int err;
This is fine.
Acked-by: Matt Mackall <mpm@selenic.com>
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2007-03-20 15:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-20 12:10 [RFC][PATCH -mm take3 0/6][resend] proposal for dynamic configurable netconsole Keiichi KII
2007-03-20 12:24 ` [RFC][PATCH -mm take3 1/6][resend] marking __init Keiichi KII
2007-03-20 15:36 ` Matt Mackall [this message]
2007-03-20 12:26 ` [RFC][PATCH -mm take3 2/6][resend] support multiple logging Keiichi KII
2007-03-20 12:34 ` Alexey Dobriyan
2007-03-22 10:03 ` Keiichi KII
2007-03-20 12:28 ` [RFC][PATCH -mm take3 3/6][resend] add interface for netconsole using sysfs Keiichi KII
2007-03-20 12:30 ` [RFC][PATCH -mm take3 4/6][resend] using symlink for the net_device Keiichi KII
2007-03-20 12:31 ` [RFC][PATCH -mm take3 5/6][resend] switch function of netpoll Keiichi KII
2007-03-20 12:34 ` [RFC][PATCH -mm take3 6/6][resend] add ioctls for adding/removing target Keiichi KII
2007-03-20 12:50 ` Alexey Dobriyan
2007-03-20 16:59 ` Stephen Hemminger
2007-03-22 10:05 ` Keiichi KII
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070320153627.GF4892@waste.org \
--to=mpm@selenic.com \
--cc=k-keiichi@bx.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).