From: Ingo Molnar <mingo@elte.hu>
To: Deepak Saxena <dsaxena@plexity.net>
Cc: samuel@sortiz.org, netdev@vger.kernel.org,
Andrew Morton <akpm@osdl.org>, Daniel Walker <dwalker@mvista.com>
Subject: Re: [PATCH -rt] Fix initialization of spinlock in irttp_dup()
Date: Wed, 21 Mar 2007 08:11:13 +0100 [thread overview]
Message-ID: <20070321071113.GA5894@elte.hu> (raw)
In-Reply-To: <20070320192233.GA14543@plexity.net>
* Deepak Saxena <dsaxena@plexity.net> wrote:
> This was found around the 2.6.10 timeframe when testing with the -rt
> patch and I believe is still is an issue. irttp_dup() does a memcpy()
> of the tsap_cb structure causing the spinlock protecting various
> fields in the structure to be duped. This works OK in the non-RT case
> but in the RT case we end up with two mutexes pointing to the same
> wait_list and leading to an OOPS. Fix is to simply initialize the
> spinlock after the memcpy().
note that memcpy based lock initialization is a problem for lockdep too.
Ingo
prev parent reply other threads:[~2007-03-21 7:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-20 19:22 [PATCH -rt] Fix initialization of spinlock in irttp_dup() Deepak Saxena
2007-03-20 21:50 ` Samuel Ortiz
2007-03-21 7:11 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321071113.GA5894@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=dsaxena@plexity.net \
--cc=dwalker@mvista.com \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).