From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [1/1] netlink: no need to crash if table does not exist.
Date: Wed, 21 Mar 2007 13:44:56 +0300 [thread overview]
Message-ID: <20070321104456.GA2637@2ka.mipt.ru> (raw)
We would already do that on init.
Some things become very confused, when nl_table is not used to store
netlink sockets.
Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
23ebdcf1f439cde050a63f33897d5b099fe08c95
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 9b69d9b..071e4d7 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -1330,8 +1330,6 @@ netlink_kernel_create(int unit, unsigned int groups,
struct netlink_sock *nlk;
unsigned long *listeners = NULL;
- BUG_ON(!nl_table);
-
if (unit<0 || unit>=MAX_LINKS)
return NULL;
--
Evgeniy Polyakov
next reply other threads:[~2007-03-21 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-21 10:44 Evgeniy Polyakov [this message]
2007-03-21 10:54 ` [1/1] netlink: no need to crash if table does not exist Patrick McHardy
2007-03-21 10:58 ` Evgeniy Polyakov
2007-03-27 23:41 ` David Miller
2007-03-28 8:43 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321104456.GA2637@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).