From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Patrick McHardy <kaber@trash.net>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [1/1] netlink: no need to crash if table does not exist.
Date: Wed, 21 Mar 2007 13:58:47 +0300 [thread overview]
Message-ID: <20070321105847.GA18221@2ka.mipt.ru> (raw)
In-Reply-To: <46010EF5.6010306@trash.net>
On Wed, Mar 21, 2007 at 11:54:45AM +0100, Patrick McHardy (kaber@trash.net) wrote:
> Evgeniy Polyakov wrote:
> > We would already do that on init.
> > Some things become very confused, when nl_table is not used to store
> > netlink sockets.
>
>
> Its unnecessary, but I don't understand what the problem is.
> Why would it be NULL and what gets confused?
There is no problem as-is, but I implement unified cache for different
sockets (currently tcp/udp/raw and netlink are supported), which does
not use that table, so I currently wrap all access code into special
ifdefs, this one can be wrapped too, but since it is not needed, it
saves couple of lines of code.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2007-03-21 10:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-21 10:44 [1/1] netlink: no need to crash if table does not exist Evgeniy Polyakov
2007-03-21 10:54 ` Patrick McHardy
2007-03-21 10:58 ` Evgeniy Polyakov [this message]
2007-03-27 23:41 ` David Miller
2007-03-28 8:43 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321105847.GA18221@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).