From: Thomas Graf <tgraf@suug.ch>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, kaber@trash.net
Subject: [NETFILTER] nfnetlink: netlink_run_queue() already checks for NLM_F_REQUEST
Date: Wed, 21 Mar 2007 13:33:04 +0100 [thread overview]
Message-ID: <20070321123304.GV521@postel.suug.ch> (raw)
In-Reply-To: <20070321001900.748961655@lsx.localdomain>
Patrick has made use of netlink_run_queue() in nfnetlink while my patches
have been waiting for net-2.6.22 to open. So this check for NLM_F_REQUEST
can go as well.
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Index: net-2.6.22/net/netfilter/nfnetlink.c
===================================================================
--- net-2.6.22.orig/net/netfilter/nfnetlink.c 2007-03-21 13:27:48.000000000 +0100
+++ net-2.6.22/net/netfilter/nfnetlink.c 2007-03-21 13:28:11.000000000 +0100
@@ -207,10 +207,6 @@ static int nfnetlink_rcv_msg(struct sk_b
return -1;
}
- /* Only requests are handled by kernel now. */
- if (!(nlh->nlmsg_flags & NLM_F_REQUEST))
- return 0;
-
/* All the messages must at least contain nfgenmsg */
if (nlh->nlmsg_len < NLMSG_SPACE(sizeof(struct nfgenmsg)))
return 0;
next prev parent reply other threads:[~2007-03-21 12:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-21 0:18 [PATCH 0/5] [PATCHSET] Netlink Patches Thomas Graf
2007-03-21 0:18 ` [PATCH 1/5] [TCP] vegas: Use type safe netlink interface Thomas Graf
2007-03-21 0:18 ` [PATCH 2/5] [TCP] westwood: " Thomas Graf
2007-03-21 0:18 ` [PATCH 3/5] [NETLINK]: Remove unused groups variable Thomas Graf
2007-03-21 0:18 ` [PATCH 4/5] [NETLINK]: Ignore !NLM_F_REQUEST messages directly in netlink_run_queue() Thomas Graf
2007-03-21 12:33 ` Thomas Graf [this message]
2007-03-21 12:37 ` [NETFILTER] nfnetlink: netlink_run_queue() already checks for NLM_F_REQUEST Patrick McHardy
2007-03-21 0:18 ` [PATCH 5/5] [NETLINK]: Ignore control messages directly in netlink_run_queue() Thomas Graf
2007-03-21 4:44 ` Patrick McHardy
2007-03-21 11:45 ` Thomas Graf
2007-03-21 11:59 ` Thomas Graf
2007-03-21 12:06 ` Patrick McHardy
2007-03-21 12:21 ` Patrick McHardy
2007-03-21 12:25 ` Thomas Graf
2007-03-21 12:25 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321123304.GV521@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).