netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Oeser <netdev@axxeo.de>
To: James Chapman <jchapman@katalix.com>
Cc: netdev@vger.kernel.org
Subject: Re: L2TP support?
Date: Thu, 22 Mar 2007 18:33:33 +0100	[thread overview]
Message-ID: <200703221833.33530.netdev@axxeo.de> (raw)
In-Reply-To: <4602AA25.6020001@katalix.com>

Hi James,

James Chapman schrieb:
> Is there interest in adding L2TP support?

Yes, if there is also a user space part somewhere.
 
> I have a patch which could be submitted for review. The PPPoL2TP driver
> presents a PPPoX socket to userspace pppd in the same way as the PPPoE
> and PPPoATM drivers. The kernel handles all data traffic, while
> userspace daemons do L2TP and PPP control message processing.

Like the pppoe-plugin for pppd? 

> In that thread, I was asked to improve the scalability of my solution by
> avoiding the socket-per-session usage imposed by the PPPoX model. 

Since that is imposed by your generic upper layer (PPPoX) this is no valid
argument against your code. (Yes, I've read that thread :-))

> Shall I post the patch?

Yes, please check your patch using the nice checklist in 
Documentation/SubmitChecklist and do it in suitable chunks 
according to Documentation/SubmittingPatches

I'm looking forward to review it!

Best Regards

Ingo Oeser

  reply	other threads:[~2007-03-22 17:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-22 16:09 L2TP support? James Chapman
2007-03-22 17:33 ` Ingo Oeser [this message]
2007-03-22 20:13   ` James Chapman
2007-03-23  7:05     ` Jorge Boncompte [DTI2]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200703221833.33530.netdev@axxeo.de \
    --to=netdev@axxeo.de \
    --cc=jchapman@katalix.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).