L2TP support?

L2TP support?

[James Chapman]

Is there interest in adding L2TP support?

I have a patch which could be submitted for review. The PPPoL2TP driver
presents a PPPoX socket to userspace pppd in the same way as the PPPoE
and PPPoATM drivers. The kernel handles all data traffic, while
userspace daemons do L2TP and PPP control message processing.

I posted an initial version of the patch in Sept 2004 (!). There was
some discussion about the use of PPPoX for L2TP in the following thread:

http://marc.info/?l=linux-netdev&m=109571479604766&w=2

In that thread, I was asked to improve the scalability of my solution by
avoiding the socket-per-session usage imposed by the PPPoX model. I
spent some time on this but was unable to come up with a better solution
than the original. Since then, the original PPPoX-based solution has
matured and is now use successfully by more than one L2TP protocol
implementation. My original work has been kept up to date with the
current kernel so could be submitted again if people want it. I didn't
want to repost it without revisiting the above thread first though... :)

Shall I post the patch?

-- 
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development

Re: L2TP support?

[Ingo Oeser]

Hi James,

James Chapman schrieb:
> Is there interest in adding L2TP support?

Yes, if there is also a user space part somewhere.
 
> I have a patch which could be submitted for review. The PPPoL2TP driver
> presents a PPPoX socket to userspace pppd in the same way as the PPPoE
> and PPPoATM drivers. The kernel handles all data traffic, while
> userspace daemons do L2TP and PPP control message processing.

Like the pppoe-plugin for pppd? 

> In that thread, I was asked to improve the scalability of my solution by
> avoiding the socket-per-session usage imposed by the PPPoX model. 

Since that is imposed by your generic upper layer (PPPoX) this is no valid
argument against your code. (Yes, I've read that thread :-))

> Shall I post the patch?

Yes, please check your patch using the nice checklist in 
Documentation/SubmitChecklist and do it in suitable chunks 
according to Documentation/SubmittingPatches

I'm looking forward to review it!

Best Regards

Ingo Oeser

Re: L2TP support?

[James Chapman]

Hi Ingo,

Ingo Oeser wrote:
> Hi James,
> 
> James Chapman schrieb:
>> Is there interest in adding L2TP support?
> 
> Yes, if there is also a user space part somewhere.

Yes there is. There's a pppd plugin which comes with the openl2tp 
project, http://sf.net/projects/openl2tp. OpenL2TP supports both LAC and 
LNS operation. A patch is also available to allow this driver to be used 
with another L2TP implementation, l2tpd.

>> I have a patch which could be submitted for review. The PPPoL2TP driver
>> presents a PPPoX socket to userspace pppd in the same way as the PPPoE
>> and PPPoATM drivers. The kernel handles all data traffic, while
>> userspace daemons do L2TP and PPP control message processing.
> 
> Like the pppoe-plugin for pppd? 

Yes. :) The plan is to submit the pppol2tp plugin for pppd for inclusion 
in the pppd distro after the kernel driver is integrated.

> Yes, please check your patch using the nice checklist in 
> Documentation/SubmitChecklist and do it in suitable chunks 
> according to Documentation/SubmittingPatches

Will do.

-- 
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development

Re: L2TP support?

[Jorge Boncompte [DTI2]]

----- Original Message ----- 
From: "James Chapman" <jchapman@katalix.com>
To: "Ingo Oeser" <netdev@axxeo.de>
Cc: <netdev@vger.kernel.org>
Sent: Thursday, March 22, 2007 9:13 PM
Subject: Re: L2TP support?


> Yes there is. There's a pppd plugin which comes with the openl2tp project, 
> http://sf.net/projects/openl2tp. OpenL2TP supports both LAC and LNS 
> operation. A patch is also available to allow this driver to be used with 
> another L2TP implementation, l2tpd.
>


    Well, I am using a modified rp-l2tp with the pppol2tp kernel module 
myself so now it accounts for three implementations I guess :-)

    -Jorge

==============================================================
Jorge Boncompte - Ingenieria y Gestion de RED
DTI2 - Desarrollo de la Tecnologia de las Comunicaciones
--------------------------------------------------------------
C/ Abogado Enriquez Barrios, 5   14004 CORDOBA (SPAIN)
Tlf: +34 957 761395 / FAX: +34 957 450380
==============================================================
- Sin pistachos no hay Rock & Roll...
- Without wicker a basket cannot be made.
==============================================================