From: Thomas Graf <tgraf@suug.ch>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: Recent net-2.6.22 patches break bootup!
Date: Fri, 23 Mar 2007 00:47:04 +0100 [thread overview]
Message-ID: <20070322234704.GA521@postel.suug.ch> (raw)
In-Reply-To: <20070322142753.52fec3ca@localhost>
* Stephen Hemminger <shemminger@linux-foundation.org> 2007-03-22 14:27
> Something is broken now. If I boot the system (Fedora) it gets to:
>
> Bringing up loopback interface: RTNETLINK answers: Invalid argument
> Dump terminated
> RTNETLINK answers: Invalid argument
> ....
>
> tg3 device eth0 does not seem to be present, delaying initialization
>
>
> then it hangs because cups won't come up without loopback
Thinko. It always returned the first message handler of a rtnl
family.
[RTNL]: Properly return rntl message handler
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Index: net-2.6.22/net/core/rtnetlink.c
===================================================================
--- net-2.6.22.orig/net/core/rtnetlink.c 2007-03-23 00:31:37.000000000 +0100
+++ net-2.6.22/net/core/rtnetlink.c 2007-03-23 00:32:52.000000000 +0100
@@ -122,10 +122,10 @@ static rtnl_doit_func rtnl_get_doit(int
struct rtnl_link *tab;
tab = rtnl_msg_handlers[protocol];
- if (tab == NULL || tab->doit == NULL)
+ if (tab == NULL || tab[msgindex].doit == NULL)
tab = rtnl_msg_handlers[PF_UNSPEC];
- return tab ? tab->doit : NULL;
+ return tab ? tab[msgindex].doit : NULL;
}
static rtnl_dumpit_func rtnl_get_dumpit(int protocol, int msgindex)
@@ -133,10 +133,10 @@ static rtnl_dumpit_func rtnl_get_dumpit(
struct rtnl_link *tab;
tab = rtnl_msg_handlers[protocol];
- if (tab == NULL || tab->dumpit == NULL)
+ if (tab == NULL || tab[msgindex].dumpit == NULL)
tab = rtnl_msg_handlers[PF_UNSPEC];
- return tab ? tab->dumpit : NULL;
+ return tab ? tab[msgindex].dumpit : NULL;
}
/**
next prev parent reply other threads:[~2007-03-22 23:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-22 12:59 [PATCH 00/12] [RESEND] rtnetlink message handler registration interface Thomas Graf
2007-03-22 12:59 ` [PATCH 01/12] [RTNL]: Message " Thomas Graf
2007-03-22 12:59 ` [PATCH 02/12] [NET] link: Use rtnl " Thomas Graf
2007-03-22 12:59 ` [PATCH 03/12] [NEIGH]: " Thomas Graf
2007-03-22 12:59 ` [PATCH 04/12] [NET] rules: " Thomas Graf
2007-03-22 13:00 ` [PATCH 05/12] [IPv4]: " Thomas Graf
2007-03-22 13:00 ` [PATCH 06/12] [PKT_SCHED] qdisc: " Thomas Graf
2007-03-22 13:00 ` [PATCH 07/12] [PKT_SCHED] cls: " Thomas Graf
2007-03-22 13:00 ` [PATCH 08/12] [PKT_SCHED] act: " Thomas Graf
2007-03-22 13:00 ` [PATCH 09/12] [DECNet]: " Thomas Graf
2007-03-22 13:07 ` Steven Whitehouse
2007-03-22 19:06 ` David Miller
2007-03-22 13:00 ` [PATCH 10/12] [IPv6]: " Thomas Graf
2007-03-22 13:00 ` [PATCH 11/12] [BRIDGE]: " Thomas Graf
2007-03-22 13:00 ` [PATCH 12/12] [RTNL]: Use rtnl registration interface for dump-all aliases Thomas Graf
2007-03-22 19:06 ` [PATCH 00/12] [RESEND] rtnetlink message handler registration interface David Miller
2007-03-22 21:27 ` Recent net-2.6.22 patches break bootup! Stephen Hemminger
2007-03-22 23:47 ` Thomas Graf [this message]
2007-03-23 4:41 ` David Miller
2007-03-23 18:07 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070322234704.GA521@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).