netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: netdev@vger.kernel.org
Subject: Re: [RFC PATCHv5 1/5] [TCP]: Add highest_sack seqno, points to globally highest SACK
Date: Sat, 24 Mar 2007 21:04:28 -0700 (PDT)	[thread overview]
Message-ID: <20070324.210428.78711276.davem@davemloft.net> (raw)
In-Reply-To: <11740704662337-git-send-email-ilpo.jarvinen@helsinki.fi>

From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Fri, 16 Mar 2007 20:41:02 +0200

> It is guaranteed to be valid only when !tp->sacked_out. In most
> cases this seqno is available in the last ACK but there is no
> guarantee for that. The new fast recovery loss marking algorithm
> needs this as entry point.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>

Patch applied, thanks Ilpo.

It's a shame we keep around multiple values which represent very
related values.  For example, this new seqno could be computed
using "fackets_out" if we knew also how many holes there were.

  parent reply	other threads:[~2007-03-25  4:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-16 18:41 [RFC PATCHv5 0/5] LOST marking rewrite Ilpo Järvinen
2007-03-16 18:41 ` [RFC PATCHv5 1/5] [TCP]: Add highest_sack seqno, points to globally highest SACK Ilpo Järvinen
2007-03-16 18:41   ` [RFC PATCHv5 2/5] [TCP]: Extracted rexmit hint clearing from the LOST marking code Ilpo Järvinen
2007-03-16 18:41     ` [RFC PATCHv5 3/5] [TCP]: Reworked recovery's TCPCB_LOST marking functions Ilpo Järvinen
2007-03-16 18:41       ` [RFC PATCHv5 4/5] [TCP]: new LOST marker optimizations Ilpo Järvinen
2007-03-16 18:41         ` [RFC PATCHv5 5/5] [TCP]: non-FACK SACK follows conservative SACK loss recovery (RFC3517) Ilpo Järvinen
2007-03-25  4:13           ` David Miller
2007-03-25  4:10         ` [RFC PATCHv5 4/5] [TCP]: new LOST marker optimizations David Miller
2007-03-25  4:09       ` [RFC PATCHv5 3/5] [TCP]: Reworked recovery's TCPCB_LOST marking functions David Miller
2007-03-25  4:05     ` [RFC PATCHv5 2/5] [TCP]: Extracted rexmit hint clearing from the LOST marking code David Miller
2007-03-25  4:04   ` David Miller [this message]
2007-03-25 21:55     ` [RFC PATCHv5 1/5] [TCP]: Add highest_sack seqno, points to globally highest SACK Ilpo Järvinen
2007-03-26  1:35       ` David Miller
2007-03-26 21:43         ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070324.210428.78711276.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ilpo.jarvinen@helsinki.fi \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).