* [PATCH 0/3]: Further reduction of direct access to skb->data
@ 2007-03-24 21:07 Arnaldo Carvalho de Melo
2007-03-25 3:20 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2007-03-24 21:07 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
Hi David,
Please take a look, at first I thought about adding a skb_copy_{from,to}_data,
that would do just the memcpy, but then skb_{copy,store}_bits seems to be fit for this
purpose, but its more costly in some cases, comments?
Available at:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22
- Arnaldo
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 0/3]: Further reduction of direct access to skb->data
2007-03-24 21:07 [PATCH 0/3]: Further reduction of direct access to skb->data Arnaldo Carvalho de Melo
@ 2007-03-25 3:20 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-03-25 3:20 UTC (permalink / raw)
To: acme; +Cc: netdev
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Date: Sat, 24 Mar 2007 18:07:06 -0300
> Hi David,
>
> Please take a look, at first I thought about adding a skb_copy_{from,to}_data,
> that would do just the memcpy, but then skb_{copy,store}_bits seems to be fit for this
> purpose, but its more costly in some cases, comments?
>
> Available at:
>
> master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22
>
I think you should make the named alias for direct memcpy()
instead, call it skb_copy_{from,to}_linear_data() so that the
assumed invariant is well documented.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-25 3:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-24 21:07 [PATCH 0/3]: Further reduction of direct access to skb->data Arnaldo Carvalho de Melo
2007-03-25 3:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).