From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ahmed S. Darwish" Subject: Re: [PATCH] net: tun/tap: fixed hw address handling Date: Mon, 26 Mar 2007 22:55:12 +0200 Message-ID: <20070326205511.GB21991@Ahmed> References: <460632E9.5030508@bristyle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Max Krasnyansky , vtun@office.satix.net, akpm@osdl.org, jgarzik@pobox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Brian Braunstein Return-path: Received: from nf-out-0910.google.com ([64.233.182.188]:50794 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753135AbXCZUzc (ORCPT ); Mon, 26 Mar 2007 16:55:32 -0400 Received: by nf-out-0910.google.com with SMTP id o25so3026902nfa for ; Mon, 26 Mar 2007 13:55:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: <460632E9.5030508@bristyle.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Sun, Mar 25, 2007 at 01:29:29AM -0700, Brian Braunstein wrote: > > From: Brian Braunstein > No need for this line. This line is used when you _forward_ another patch from others. Signed-off-by is enough > > Signed-off-by: Brian Braunstein > > --- > > Kernel Version: 2.6.20.4 > It's always better to generate the patch against the latest -rc kernel. > --- linux-2.6.20.4-ORIG/drivers/net/tun.c 2007-03-23 > 12:52:51.000000000 -0700 > +++ linux-2.6.20.4/drivers/net/tun.c 2007-03-25 00:44:20.000000000 -0700 > @@ -18,6 +18,10 @@ > /* > * Changes: > * > + * Brian Braunstein 2007/03/23 > + * Fixed hw address handling. Now net_device.dev_addr is kept > consistent Your mailer still wrap the long lines mistakenly as it did in the first version of the patch. Regards, -- Ahmed S. Darwish http://darwish.07.googlepages.com