From: David Miller <davem@davemloft.net>
To: tgraf@suug.ch
Cc: jarkao2@o2.pl, netdev@vger.kernel.org, muli@il.ibm.com
Subject: Re: [RESEND] [NET] fib_rules: Flush route cache after rule modifications
Date: Wed, 28 Mar 2007 11:24:17 -0700 (PDT) [thread overview]
Message-ID: <20070328.112417.08322226.davem@davemloft.net> (raw)
In-Reply-To: <20070328154903.GO521@postel.suug.ch>
From: Thomas Graf <tgraf@suug.ch>
Date: Wed, 28 Mar 2007 17:49:03 +0200
> * Jarek Poplawski <jarkao2@o2.pl> 2007-03-28 13:19
> > I hope I'm wrong, but isn't this at the cost of admins
> > working with long rules' sets, which (probably) take extra
> > time now?
>
> That's right, it makes the insert and delete operation more
> expensive.
>
> A compromise would be to delay the flushing and wait for
> some time (default 2 seconds) whether more rules or routes
> are being added before flushing.
Another idea Thomas and I tossed around was to have some kind of way
for the rule insertion to indicate that the flush should be deferred
and I kind of prefer that explicitness.
By default it's better the flush immediately, because the old
behavior is totally unexpected. "I insert a rule and it dosn't
show up?", nobody expects that.
next prev parent reply other threads:[~2007-03-28 18:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-27 13:38 [RESEND] [NET] fib_rules: Flush route cache after rule modifications Thomas Graf
2007-03-27 20:57 ` David Miller
2007-03-28 11:19 ` Jarek Poplawski
2007-03-28 15:49 ` Thomas Graf
2007-03-28 18:24 ` David Miller [this message]
2007-03-28 19:34 ` Thomas Graf
2007-03-28 19:40 ` David Miller
2007-03-29 10:03 ` Jarek Poplawski
2007-03-29 10:15 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070328.112417.08322226.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jarkao2@o2.pl \
--cc=muli@il.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).