netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: kaber@trash.net, netdev@vger.kernel.org
Subject: Re: KERNEL: assertion ((int)tp->sacked_out >= 0) failed at net/ipv4/tcp_input.c (2626)
Date: Wed, 28 Mar 2007 12:06:04 -0700 (PDT)	[thread overview]
Message-ID: <20070328.120604.38712657.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0703281543460.14473@kivilampi-30.cs.helsinki.fi>

From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Wed, 28 Mar 2007 16:24:40 +0300 (EEST)

> It seems I'm being guilty to this one, Dave please apply to net-2.6.22 
> (besides this I think the tcp_sync_left_out should be changed but I'll 
> prepare a patch for that later). Btw, how should this kind of email with 
> some non-patch description+patch be formatted?).

Thanks for figuring out the problem so quickly, this formatting
is fine.

> [PATCH] [TCP]: Timedout loop must skip SACKed skbs too while marking
> 
> Marking skb with both S and L is invalid, and that could easily
> happen in the timedout loop. Later on the tcp_sync_left_out
> reduces sacked_out if lost_out + sacked_out > packets_out and
> then eventually sacked_out underflows triggering a debug trap in
> tcp_clean_rtx_queue.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>

Patch applied, thanks a lot!

      reply	other threads:[~2007-03-28 19:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-28 12:03 KERNEL: assertion ((int)tp->sacked_out >= 0) failed at net/ipv4/tcp_input.c (2626) Patrick McHardy
2007-03-28 13:24 ` Ilpo Järvinen
2007-03-28 19:06   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070328.120604.38712657.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ilpo.jarvinen@helsinki.fi \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).