From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] [TCP]: Rexmit hint must be cleared instead of setting it
Date: Wed, 28 Mar 2007 12:14:05 -0700 (PDT) [thread overview]
Message-ID: <20070328.121405.49244759.davem@davemloft.net> (raw)
In-Reply-To: <20070328.120709.35017257.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 28 Mar 2007 12:07:09 -0700 (PDT)
> From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
> Date: Wed, 28 Mar 2007 16:31:50 +0300 (EEST)
>
> > Stupid error from my side. Even though now that I noticed this,
> > I hoped it would have been an optimization but no, the counter
> > hint is then incorrect. Thus clearing is necessary for now (I
> > still suspect though that this path is never executed).
> >
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
>
> Better safe than sorry :-)
>
> We can start putting more aggressive assertions around if you'd
> like to get some invariants like that validated.
In case it's not clear I did apply this patch.
next prev parent reply other threads:[~2007-03-28 19:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-28 13:31 [PATCH] [TCP]: Rexmit hint must be cleared instead of setting it Ilpo Järvinen
2007-03-28 19:07 ` David Miller
2007-03-28 19:14 ` David Miller [this message]
2007-03-28 19:29 ` Ilpo Järvinen
2007-03-28 19:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070328.121405.49244759.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).