From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: net nasties in davem's tree Date: Thu, 29 Mar 2007 19:06:02 -0700 (PDT) Message-ID: <20070329.190602.116354248.davem@davemloft.net> References: <20070329183730.566f41c6.akpm@linux-foundation.org> <20070329.190317.26277628.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: akpm@linux-foundation.org Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:51846 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752579AbXC3CGF (ORCPT ); Thu, 29 Mar 2007 22:06:05 -0400 In-Reply-To: <20070329.190317.26277628.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: David Miller Date: Thu, 29 Mar 2007 19:03:17 -0700 (PDT) > From: Andrew Morton > Date: Thu, 29 Mar 2007 18:37:30 -0700 > > > drivers/net/3c523.c: In function 'elmc_send_packet': > > drivers/net/3c523.c:1148: warning: passing argument 2 of 'skb_copy_from_linear_data' discards qualifiers from pointer target type > > drivers/net/ni52.c: In function 'ni52_send_packet': > > drivers/net/ni52.c:1185: warning: passing argument 2 of 'skb_copy_from_linear_data' discards qualifiers from pointer target type > > We should probably mark the "to" argument to skb_copy_from_linear_data() > as const, I'll take care of that. > > Thanks for the report. My bad, what's going on in the first case is the driver has "volatile disease". I'll add back the (char *) cast that was in the original memcpy().